From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA72C433DF for ; Thu, 9 Jul 2020 20:21:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1875920720 for ; Thu, 9 Jul 2020 20:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Do0vG5lJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1875920720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 887136B0003; Thu, 9 Jul 2020 16:21:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80FCE6B0005; Thu, 9 Jul 2020 16:21:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D8876B0006; Thu, 9 Jul 2020 16:21:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 589286B0003 for ; Thu, 9 Jul 2020 16:21:25 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C363B2C88 for ; Thu, 9 Jul 2020 20:21:24 +0000 (UTC) X-FDA: 77019657288.04.fifth71_100c91226ec8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 9545280105D4 for ; Thu, 9 Jul 2020 20:21:24 +0000 (UTC) X-HE-Tag: fifth71_100c91226ec8 X-Filterd-Recvd-Size: 3767 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 20:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=WcH5zbqRRAqRCq+L5gvQXrTIo3IkGu7I41whfKm6e/A=; b=Do0vG5lJQV5lqLiY9kq1e3iBs+ bIhRJqe2jHOwU0yYTx1azLH8dZuOtSD4vMyMTORsWigR7G+1aB8H+TsjRPJEXKIIVMpKRfo9uqK8L sqAnWmY1JFK2y0mKw+cgQGaGIvYBS2ikW26wYuUB1pffVLwVngMnBu4xPbH91RCjcHsqBpoGVskPR NJZ78hoO9o8Gb2RzzN3ioeTv9xMx9KXoUyPOLfbC/F5XYWnTCTWfcxu6mIcz7Ito/5rUt4muTygLX C4TCO/Rdl3CVV9636FksrWTdEM2pybDaIVOkp5WYOYceKWVCJOist88uhQbzetkM9y4JHokygnGpw JQZcBgYA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtd2o-0001tz-9g; Thu, 09 Jul 2020 20:21:22 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , Vlastimil Babka , John Hubbard , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport Subject: [PATCH v2 2/6] mm: Dump compound page information on a second line Date: Thu, 9 Jul 2020 21:21:13 +0100 Message-Id: <20200709202117.7216-3-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200709202117.7216-1-willy@infradead.org> References: <20200709202117.7216-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 9545280105D4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Simplify both the implementation and the output by splitting all the compound page information onto a second line. Reported-by: John Hubbard Signed-off-by: Matthew Wilcox (Oracle) --- mm/debug.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/mm/debug.c b/mm/debug.c index e5de63406b59..f35c1ae1a7a5 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -89,27 +89,21 @@ void __dump_page(struct page *page, const char *reaso= n) */ mapcount =3D PageSlab(head) ? 0 : page_mapcount(page); =20 - if (compound) + pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n", + page, page_ref_count(head), mapcount, mapping, + page_to_pgoff(page)); + if (compound) { if (hpage_pincount_available(page)) { - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p " - "index:%#lx head:%px order:%u " - "compound_mapcount:%d compound_pincount:%d\n", - page, page_ref_count(head), mapcount, - mapping, page_to_pgoff(page), head, - compound_order(head), compound_mapcount(page), - compound_pincount(page)); + pr_warn("head:%px order:%u compound_mapcount:%d compound_pincount:%d\= n", + head, compound_order(head), + compound_mapcount(head), + compound_pincount(head)); } else { - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p " - "index:%#lx head:%px order:%u " - "compound_mapcount:%d\n", - page, page_ref_count(head), mapcount, - mapping, page_to_pgoff(page), head, - compound_order(head), compound_mapcount(page)); + pr_warn("head:%px order:%u compound_mapcount:%d\n", + head, compound_order(head), + compound_mapcount(head)); } - else - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n", - page, page_ref_count(page), mapcount, - mapping, page_to_pgoff(page)); + } if (PageKsm(page)) type =3D "ksm "; else if (PageAnon(page)) --=20 2.27.0