From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ADC1C433DF for ; Thu, 9 Jul 2020 20:55:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F48E2076A for ; Thu, 9 Jul 2020 20:55:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F48E2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DA226B0005; Thu, 9 Jul 2020 16:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A3E6B0006; Thu, 9 Jul 2020 16:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 879506B0007; Thu, 9 Jul 2020 16:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 739966B0005 for ; Thu, 9 Jul 2020 16:55:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 370132DFC for ; Thu, 9 Jul 2020 20:55:33 +0000 (UTC) X-FDA: 77019743346.28.tray37_200a1c726ec8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 14A0C6C09 for ; Thu, 9 Jul 2020 20:55:33 +0000 (UTC) X-HE-Tag: tray37_200a1c726ec8 X-Filterd-Recvd-Size: 4713 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 20:55:32 +0000 (UTC) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 069KVo0W069119; Thu, 9 Jul 2020 16:55:30 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 325kgy7sxe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 16:55:30 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 069KeuEv002460; Thu, 9 Jul 2020 20:55:27 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma02fra.de.ibm.com with ESMTP id 325mr2s88h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 20:55:27 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 069KsAp865732724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Jul 2020 20:54:10 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 648C342042; Thu, 9 Jul 2020 20:54:10 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8518242041; Thu, 9 Jul 2020 20:54:09 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.204.222]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 9 Jul 2020 20:54:09 +0000 (GMT) Date: Thu, 9 Jul 2020 23:54:07 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , John Hubbard , "Kirill A. Shutemov" , William Kucharski Subject: Re: [PATCH v2 0/6] Improvements for dump_page() Message-ID: <20200709205407.GK781326@linux.ibm.com> References: <20200709202117.7216-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200709202117.7216-1-willy@infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-09_10:2020-07-09,2020-07-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 suspectscore=1 bulkscore=0 priorityscore=1501 mlxscore=0 adultscore=0 clxscore=1011 malwarescore=0 mlxlogscore=999 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007090135 X-Rspamd-Queue-Id: 14A0C6C09 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 09, 2020 at 09:21:11PM +0100, Matthew Wilcox (Oracle) wrote: > Thanks to everyone for your feedback on v1. I haven't added any acks > from v1 because most of the patches have changed substantially from v1. Aside from my aesthetic preference to have printk continuation line below the opening '(' rather then full tab indented the patches look good. Acked-by: Mike Rapoport > Here's a sample dump of a pagecache tail page with all of the patches applied: > > page:000000006d1c49ca refcount:6 mapcount:0 mapping:00000000136b8d90 index:0x109 pfn:0x6c645 > head:000000008bd38076 order:2 compound_mapcount:0 compound_pincount:0 > aops:xfs_address_space_operations ino:800042 dentry name:"fd" > flags: 0x4000000000012014(uptodate|lru|private|head) > raw: 4000000000000000 ffffd46ac1b19101 ffffffff00000202 dead000000000004 > raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000 > head: 4000000000012014 ffffd46ac1b1bbc8 ffffd46ac1b1bc08 ffff91976f659560 > head: 0000000000000108 ffff919773220680 00000006ffffffff 0000000000000000 > page dumped because: testing > > Matthew Wilcox (Oracle) (6): > mm: Handle page->mapping better in dump_page > mm: Dump compound page information on a second line > mm: Print head flags in dump_page > mm: Switch dump_page to get_kernel_nofault > mm: Print the inode number in dump_page > mm: Print hashed address of struct page > > mm/debug.c | 75 +++++++++++++++++++++++++----------------------------- > 1 file changed, 35 insertions(+), 40 deletions(-) > > -- > 2.27.0 > -- Sincerely yours, Mike.