From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED2CC433E0 for ; Fri, 10 Jul 2020 13:50:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFA9E206A5 for ; Fri, 10 Jul 2020 13:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jA23nciz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFA9E206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 244CA8D0002; Fri, 10 Jul 2020 09:50:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CC6C8D0001; Fri, 10 Jul 2020 09:50:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BC148D0002; Fri, 10 Jul 2020 09:50:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id E4B718D0001 for ; Fri, 10 Jul 2020 09:50:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D4CD6C17 for ; Fri, 10 Jul 2020 13:50:02 +0000 (UTC) X-FDA: 77022299844.01.mom54_500f16a26ece Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 7BD0460001CCA57D for ; Fri, 10 Jul 2020 13:50:02 +0000 (UTC) X-HE-Tag: mom54_500f16a26ece X-Filterd-Recvd-Size: 3621 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 13:50:01 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id b25so6518465ljp.6 for ; Fri, 10 Jul 2020 06:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3+t1FJBai3MN8X36lR9GDBEz4WelHJVPns0+ZhtUct0=; b=jA23ncizNlqSIf+H6bc/jICF+AF8OgUYhA4tpQ9PVgl5Z96Jy3w5bblIYwTEhY1Zsl tCa23GrDnLtVZdstCMJsfsMxYplVybyr9qQ2pvsEr7gEeIRJMpv2I/+lu3ZT4FgAV/Iy Tyr248STPS1LuELqZ/yOQZPGUg47TwUmRgQgs2yOv4aJ2p6rD63jvIemUiQ8hGBF3cs+ f5sjwlJajoPd0GX85mXvkuf3lHdPWCFCQNaevFBC1A7dthU2b6CgF/Rqjc178aIVIC8g GMsNCWZCa4DKDP6dpnXH2NFmIwH+hpo5ccRtn/gLWFuCl8WeMT+CMdGJrgHrhS/6TbJY ZAow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3+t1FJBai3MN8X36lR9GDBEz4WelHJVPns0+ZhtUct0=; b=YsaX/5nPhaUPA/2MhZ/F2F8biOo9rsEB3yxP2QqAwr+y1y0QaGtLE8hgFOPO/lCT+s gLknlrs3ms6AtTSQqWe36t67DJoVG6CldLxoa4rvj5AKsEAHYpY/aqnWY9Bs51hcCXh5 CysSk8htgHArZErqS/QloZvDFh7UKTUdYyoRgPKdd+1KfvitwcDozRBqHZwmdzQB3kd6 xf/IDav2z19d+J9/5TwniKEV36qTuqu4x9B7DYNuhcuFLnG1OFNSklUSc7GbPCszofyG MSAl1IFMaRkPervFwT3i4RPJDQreEfDH8Z9/tTW1G7JvyBRtpKr+dlVbua/ZhYyJSfOL iE8w== X-Gm-Message-State: AOAM532IhWpU+YxQDf724CHMwMwZ1FWxn02MPenBFvj6Ld8duAQaanAt RyvXCgh3owfAWv4ZaKnIQuA= X-Google-Smtp-Source: ABdhPJzSWBbYtX7hpYL2c5BfJVOpZx1iPV/QFc7eHwtKBsNjOPBFS1izv/YSHe5lPqVNSUuFiqiUTw== X-Received: by 2002:a2e:a413:: with SMTP id p19mr29908100ljn.145.1594389000380; Fri, 10 Jul 2020 06:50:00 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id g2sm2763463ljj.90.2020.07.10.06.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 06:49:58 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 10 Jul 2020 15:49:56 +0200 To: Matthew Wilcox Cc: Tian Tao , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed Message-ID: <20200710134956.GA14549@pc636> References: <1594383472-52983-1-git-send-email-tiantao6@hisilicon.com> <20200710124323.GJ12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710124323.GJ12769@casper.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 7BD0460001CCA57D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000084, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote: > > In fact "vmalloc=" cmdline option is not available on many > > platforms.When the user encounters this error, add the correct > > hint to prevent misleading. > > i don't think this is an improvement. > Matthew, maybe it should not be considered as improvements? It is rather an extra information that indicates that your ARCH may not support "vmalloc" early parameter. Thanks! -- Vlad Rezki