From: Matthew Wilcox <willy@infradead.org>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed
Date: Fri, 10 Jul 2020 14:53:01 +0100 [thread overview]
Message-ID: <20200710135301.GM12769@casper.infradead.org> (raw)
In-Reply-To: <20200710134956.GA14549@pc636>
On Fri, Jul 10, 2020 at 03:49:56PM +0200, Uladzislau Rezki wrote:
> > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote:
> > > In fact "vmalloc=<size>" cmdline option is not available on many
> > > platforms.When the user encounters this error, add the correct
> > > hint to prevent misleading.
> >
> > i don't think this is an improvement.
> >
> Matthew, maybe it should not be considered as improvements?
Every patch should be an improvement along some dimension. This doesn't
feel like an improvement in any way.
> It is rather an extra information that indicates that your
> ARCH may not support "vmalloc" early parameter.
If anything needs to be improved, it's the documentation, not this
error message.
next prev parent reply other threads:[~2020-07-10 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:17 [PATCH v3] vmalloc: Add the right hint when vmalloc failed Tian Tao
2020-07-10 12:43 ` Matthew Wilcox
2020-07-10 13:49 ` Uladzislau Rezki
2020-07-10 13:53 ` Matthew Wilcox [this message]
2020-07-10 14:04 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710135301.GM12769@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).