From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B83C433E7 for ; Fri, 10 Jul 2020 14:04:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 194CE20836 for ; Fri, 10 Jul 2020 14:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FdeyBHoP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 194CE20836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E7368D000C; Fri, 10 Jul 2020 10:04:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C6E8D0001; Fri, 10 Jul 2020 10:04:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636348D000C; Fri, 10 Jul 2020 10:04:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 4E9A38D0001 for ; Fri, 10 Jul 2020 10:04:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0D90A18020B34 for ; Fri, 10 Jul 2020 14:04:46 +0000 (UTC) X-FDA: 77022336972.11.end16_0003dbe26ece Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id E830A180F9831 for ; Fri, 10 Jul 2020 14:04:43 +0000 (UTC) X-HE-Tag: end16_0003dbe26ece X-Filterd-Recvd-Size: 4420 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 14:04:43 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id h19so6540967ljg.13 for ; Fri, 10 Jul 2020 07:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FohwNfXrZ64dI/A6dzP4B8r132U3m58v5WNQmAc787c=; b=FdeyBHoPZ/YazdNbuptBYqPxCsSqUwT3eKPkBfbE2ygIjlnl7YKFCbnvAxJ/+HQWn8 MJNJ3lz8nHH1iOkADufts1pqX5u+DmzlF96mXCPwmr3x1qC0WclhB2qmRHZJjXddhDHX FqMANUwWLDw8iFQ1qXODdXI+xnmxp6Eb0sNojyP0tToYPCjJAuYF1yyp6FYKVWVLpDFO dpQwssxsdswmxdqWVv2G3c3382AFAwoN5jcM4bUzEphLfgYzgszyGQ0oPZP2btBdnCje 8jKg8pDxpixH206ZyW/v1AHMN8bY69CZwJYpiFBjELqqReUDUIKAiRHS7KCrymk3LipT fnGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FohwNfXrZ64dI/A6dzP4B8r132U3m58v5WNQmAc787c=; b=WcpCe/UzVql30exmJmlJ1C5s+UrjUro4F+j9kzUpQjXZV+vV14e1aF+jpyFlNXVwYi /pTLJDgDQS07rV3G64aoVfERSrphyb2qgVyz5JSZ+hklwl16LeoBTjuhoQ60Oq1/Ffa/ 1VYp3U+kCTf5DM5gVLNwwKVwS7QebpC1RYehPhYDezR4WIl12qqCGc5xKdtFXhnzZptf egu2+NBGGV6dzOYOX1HsVg+VhwrrJzSe5XYQudUMYn1PInj6xHxnHWprLcHbv9Q3XG0T 2BZGhSrOoTe3Qh5YBVkrkP8tGxaEd2vZKj1N9GPrBQJUfgmtK3bwrrnKsdNgPy0OAvY5 XYjg== X-Gm-Message-State: AOAM530+LkiK9U4np0hazfzvb9OgQDNSgDK6dG3vNQC0auE5HTMKrhO7 SZFVgqB886d6mw+dvoTJgsU= X-Google-Smtp-Source: ABdhPJx9Xj8F3jJ+3vIeNuvenAc1On3KXSkIWPuNL3idV6WigPnS/KTN7FKGqctRoNTjzb/hMSlPhw== X-Received: by 2002:a2e:870b:: with SMTP id m11mr26798970lji.269.1594389882122; Fri, 10 Jul 2020 07:04:42 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id j25sm2194769lfh.95.2020.07.10.07.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 07:04:41 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 10 Jul 2020 16:04:39 +0200 To: Matthew Wilcox Cc: Uladzislau Rezki , Tian Tao , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed Message-ID: <20200710140439.GA14846@pc636> References: <1594383472-52983-1-git-send-email-tiantao6@hisilicon.com> <20200710124323.GJ12769@casper.infradead.org> <20200710134956.GA14549@pc636> <20200710135301.GM12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710135301.GM12769@casper.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: E830A180F9831 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 02:53:01PM +0100, Matthew Wilcox wrote: > On Fri, Jul 10, 2020 at 03:49:56PM +0200, Uladzislau Rezki wrote: > > > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote: > > > > In fact "vmalloc=" cmdline option is not available on many > > > > platforms.When the user encounters this error, add the correct > > > > hint to prevent misleading. > > > > > > i don't think this is an improvement. > > > > > Matthew, maybe it should not be considered as improvements? > > Every patch should be an improvement along some dimension. This doesn't > feel like an improvement in any way. > > > It is rather an extra information that indicates that your > > ARCH may not support "vmalloc" early parameter. > > If anything needs to be improved, it's the documentation, not this > error message. > As i mentioned before, i do not have a strong opinion about this patch. From the other hand improving that message looks normal to me. Especially in a context that it took a time to understand that ARM64 does not support it, so we have had a precedent. I am talking about author of this patch. -- Vlad Rezki