From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525F3C433DF for ; Fri, 10 Jul 2020 20:16:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04CF92076A for ; Fri, 10 Jul 2020 20:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcWv/Ng+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04CF92076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E2118D0001; Fri, 10 Jul 2020 16:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 691B06B0003; Fri, 10 Jul 2020 16:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A87B8D0001; Fri, 10 Jul 2020 16:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 449716B0002 for ; Fri, 10 Jul 2020 16:16:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E070D181AEF15 for ; Fri, 10 Jul 2020 20:16:39 +0000 (UTC) X-FDA: 77023274118.02.north89_11007a026ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 93F271000A8BDABB for ; Fri, 10 Jul 2020 20:04:22 +0000 (UTC) X-HE-Tag: north89_11007a026ed1 X-Filterd-Recvd-Size: 5302 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 20:04:22 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id e4so7803478ljn.4 for ; Fri, 10 Jul 2020 13:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=upv6HyhLP4aEGK32Lyt7RFYLTeMC908RT7hWhpDKjXI=; b=YcWv/Ng+Xe1od3A8ERpoizba2TI4fOXam8+d/PKzLH1WMrRay6cUfpS9+pYFQ+2onz GjsBKG6YoJtYoCIArRhoo0biLuR+DSvJ3g08l0kbb0z0LbcyNgS8gPxLj4XMMDdPSzee vClhD5FOgLSaxVRd+S4amfNeWlO+DmfGPg+D7Z0aV24kQ2WVWGLUGPbtsaiFPy/QY8yZ /KMN8De4AzD7YRRwndFFahHMpfLAN2NVvJPomAQ/SgVCrW1+JyVfhn9u+EY76pfDgzV3 fSE5s2qz6EcKd86NYECjO6i6QzezcAMKW/wFCb+tyDKYoNbQ2IlKnoIuiVyX6vDPLgQy T4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=upv6HyhLP4aEGK32Lyt7RFYLTeMC908RT7hWhpDKjXI=; b=FFYaUDhEr8EFn+wIRFsPd0lsQ+Ka6XU04hYiojVHCB6JbT71C7QZzLKWnSsKXTvRYv XqFBqeZrqC5ZackZK4xkysqR6V35TU456RsDcr7Bujkg+nJbNoF4YLyotdhK5fcfHdpp ysnjieSb1y/b/xUtN+zgeURpJfiVfEXAtgtpWOcjVTXQQDwlVUtJ5O3LhYL63phInaH+ JnlbpoYvdoCTrk+yQfHl0m7FcOUtj92EmdDGjn0C4Dap1xkyPIQe34eqUrP3SDK9oF+M hIaMpcHo9Xz9mMp9HoWJl4SjAHwZObEPbUGDnJRwhj7KvoaWr0zOGHM4vKT40UapxqlV OXQw== X-Gm-Message-State: AOAM532RTvSY/LUwZWxOMktrxNmcDTWonMa2evVQnjHtLF1ZoyKrB2RZ f5wbanWbhr8aeoCSo1pxWVA= X-Google-Smtp-Source: ABdhPJw8mISKfQOiTyr3De+IS4+Mzm837tlLnCygkmps6B5cLYI4ac33g/i9u8JIZ+YLi6GoLlaWHw== X-Received: by 2002:a2e:9316:: with SMTP id e22mr38667350ljh.393.1594411461147; Fri, 10 Jul 2020 13:04:21 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id e16sm2236787ljn.12.2020.07.10.13.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 13:04:20 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 10 Jul 2020 22:04:18 +0200 To: Matthew Wilcox Cc: Uladzislau Rezki , Andrew Morton , linux-mm@kvack.org, LKML , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH 1/1] mm/vmalloc.c: Add an error message if two areas overlap Message-ID: <20200710200418.GA19627@pc636> References: <20200710194042.2510-1-urezki@gmail.com> <20200710194406.GP12769@casper.infradead.org> <20200710200030.GB19487@pc636> <20200710200138.GQ12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710200138.GQ12769@casper.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 93F271000A8BDABB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 09:01:38PM +0100, Matthew Wilcox wrote: > On Fri, Jul 10, 2020 at 10:00:30PM +0200, Uladzislau Rezki wrote: > > On Fri, Jul 10, 2020 at 08:44:06PM +0100, Matthew Wilcox wrote: > > > On Fri, Jul 10, 2020 at 09:40:42PM +0200, Uladzislau Rezki (Sony) wrote: > > > > Before triggering a BUG() it would be useful to understand > > > > how two areas overlap between each other. Print information > > > > about start/end addresses of both VAs and their addresses. > > > > > > > > For example if both are identical it could mean double free. > > > > > > > > Signed-off-by: Uladzislau Rezki (Sony) > > > > --- > > > > mm/vmalloc.c | 10 +++++++++- > > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > index 5a2b55c8dd9a..1679b01febcd 100644 > > > > --- a/mm/vmalloc.c > > > > +++ b/mm/vmalloc.c > > > > @@ -549,8 +549,13 @@ find_va_links(struct vmap_area *va, > > > > else if (va->va_end > tmp_va->va_start && > > > > va->va_start >= tmp_va->va_end) > > > > link = &(*link)->rb_right; > > > > - else > > > > + else { > > > > + pr_err("Overlaps: 0x%px(0x%lx-0x%lx), 0x%px(0x%lx-0x%lx)\n", > > > > + va, va->va_start, va->va_end, tmp_va, > > > > + tmp_va->va_start, tmp_va->va_end); > > > > > > It might be helpful to have a "vmalloc:" prefix to that string to indicate > > > where to start searching. And I don't think we're supposed to use %px > > > without a really good justification these days. > > > > > That makes sense, i will add such prefix for sure. As for %px i can just > > use a casting to (unsigned long) and 0x%lx prefix. > > That's not the point. Linus wants us to not display actual pointers to > the user. > Ahh, Got it! Then i will just remove information about addresses of two VAs. Hope that will work. -- Vlad Rezki