From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4ABC433ED for ; Wed, 15 Jul 2020 10:37:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6987220656 for ; Wed, 15 Jul 2020 10:37:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="RMFOXHt1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6987220656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A755A6B0002; Wed, 15 Jul 2020 06:37:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A24996B0003; Wed, 15 Jul 2020 06:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93CBB6B0005; Wed, 15 Jul 2020 06:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 7EA5A6B0002 for ; Wed, 15 Jul 2020 06:37:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E3890181AC9CC for ; Wed, 15 Jul 2020 10:37:11 +0000 (UTC) X-FDA: 77039957862.21.tin25_4516e2926ef8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id B6602180442C0 for ; Wed, 15 Jul 2020 10:37:11 +0000 (UTC) X-HE-Tag: tin25_4516e2926ef8 X-Filterd-Recvd-Size: 4764 Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 10:37:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594809431; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=pYgx74LtrBLVD12x3ELyZuAqEdnOVxhRlDanXsj1kC8=; b=RMFOXHt1j2NDIQLQcgkVuebfRQK9mrIOc457qf0pf9bL2c8Y30zQUEty0XdVdj4XE6c3qG1A Gxk1ZE9c5cJp265E/4Zacq4bnu082Elnb5wRT9+yRpI+ICVAtFEGWA/RVfsJSVa3wAKEzzdZ 2fos5Ek9Ewh90F/6SKdkXFZX4WU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n18.prod.us-west-2.postgun.com with SMTP id 5f0edc4db35196d59d5e5295 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Jul 2020 10:37:01 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 43B6CC433B2; Wed, 15 Jul 2020 10:37:01 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 639D1C433CA; Wed, 15 Jul 2020 10:36:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 639D1C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 04/16] b43: Remove uninitialized_var() usage From: Kalle Valo In-Reply-To: <20200620033007.1444705-5-keescook@chromium.org> References: <20200620033007.1444705-5-keescook@chromium.org> To: Kees Cook Cc: linux-kernel@vger.kernel.org, Kees Cook , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200715103701.43B6CC433B2@smtp.codeaurora.org> Date: Wed, 15 Jul 2020 10:37:01 +0000 (UTC) X-Rspamd-Queue-Id: B6602180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just initialize this variable to NULL. > No later NULL deref is possible due to the early returns outside of the > (phy->rev >= 7 && phy->rev < 19) case, which explicitly tests for NULL. > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ > > Fixes: 58619b14d106 ("b43: move under broadcom vendor directory") > Signed-off-by: Kees Cook > Reviewed-by: Nick Desaulniers 2 patches applied to wireless-drivers-next.git, thanks. 800e7a205a0f b43: Remove uninitialized_var() usage f8279dad4e36 rtlwifi: rtl8192cu: Remove uninitialized_var() usage -- https://patchwork.kernel.org/patch/11615573/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches