Re: [PATCH 1/1] rcu/tree: Drop the lock before entering to page allocator

Uladzislau Rezki
2020-07-15T19:37:05Z

On Wed, Jul 15, 2020 at 09:32:50PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-07-15 21:02:43 [+0200], Uladzislau Rezki wrote:
> >
> > <snip>
> > spin_lock();
> > __get_free_page(GFP_NOWAIT | __GFP_NOWARN);
> > spin_unlock();
> > <snip>
> >
> > Also, please note we do it for regular kernel.
>
> ach right okay then.
>
> > >
> > > What happened to the part where I asked for a spinlock_t?
> > >
> > What do you mean?
>
> Please drop that raw_spinlock_t for the kfree_rcu() based locking and
> use just a plain spinlock_t for the locking. Then you can keep the same
> code flow for RT and !RT without any special cases and everything.
>
Ahhh... That i see :)

I guess it is up to Paul. I wrote my thoughts. I have only one concern
that i explained in my previous mails.

Thank you, Sebastian, for your comments!

--
Vlad Rezki