From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591B1C433E0 for ; Mon, 20 Jul 2020 08:43:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1784F2176B for ; Mon, 20 Jul 2020 08:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="e6djTCYW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1784F2176B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A25DF6B0007; Mon, 20 Jul 2020 04:43:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AF706B0008; Mon, 20 Jul 2020 04:43:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F656B000A; Mon, 20 Jul 2020 04:43:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 758ED6B0007 for ; Mon, 20 Jul 2020 04:43:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3CB5821984E for ; Mon, 20 Jul 2020 08:43:54 +0000 (UTC) X-FDA: 77057816388.12.bone38_150fc9126f23 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 0F6B3181E3F99 for ; Mon, 20 Jul 2020 08:43:54 +0000 (UTC) X-HE-Tag: bone38_150fc9126f23 X-Filterd-Recvd-Size: 3988 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 08:43:53 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id z24so19308809ljn.8 for ; Mon, 20 Jul 2020 01:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=e6djTCYWEj2Fmi95lUFWKgkZcJHCyeTSf7Syl643UoYLetz7sglV0iZEAzz9bdhAWy AV2kduveWFWI+JWAlK2oNtidKKo/CEuAaKD0MJ5Pp2tRK5UEZOnqUQB+URJ8qpBiS3E0 7BLXT/fa/imiZu0Qgtj10PZL/JBmO+Pz1dtSqFtftbPH5ryJlZX1B4ohWJEXiBEEvDCm QXR5JmQwVkqYm8SkgaPhzlXf0D9fpQhWmfdlnKXyWsNJSVXFpVk2mp2087rkuizdb6pR gp9yJayr7YSyuNloyVlOeoyOmDejlgs1239X59/cPzNKO7ss8eXDNgChuv/x7qWhxATI 9lQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=OYwKOXFjpYJYGrtlbTdofp2RddSzSxpSvdjbiFzLK3yqqRszzgr3ut0BKHbSE02zRS jPcrIinb/6no4AW7uukGgG5FqRMwk9b6/X/R2cVg1gJw1auhvIyqPihcFzn6YIwaf3r7 3phbxk/lxNLj21HnsxbFturWFBBOzTHn4Sohru/azCAk87gs4wB9EPUz1U3p6EJt2zVw X2SkCHyDTEoRuc7zaFHfvKfUOu4uXW+D5kX6SFWICdIk2yvQBD6UZnVzmgXOWz6A+Dll 9hjwssj0g5Y9G8weU71W+L2fbR0qREF+xyTIVsh8QCHXIc8BVHceDh9TTSfDqXaOBegP 77Aw== X-Gm-Message-State: AOAM532A+OyOdup9OnAbg+kHS6mOsiLINEk9K461ROKbyJYxuooGu9LC oRaidWEJUZezLkl5AYAfiOiRpQ== X-Google-Smtp-Source: ABdhPJxDpc+xGL9gCU4hB6aJTaR2Pfe9WrNdwYB5SAzencPCUUdqx2ZecSSoIxaZ/WyEMlHA9/Z3Zg== X-Received: by 2002:a05:651c:1057:: with SMTP id x23mr9133434ljm.116.1595234632369; Mon, 20 Jul 2020 01:43:52 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s62sm3101085lja.100.2020.07.20.01.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 01:43:51 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E7866102393; Mon, 20 Jul 2020 11:43:51 +0300 (+03) Date: Mon, 20 Jul 2020 11:43:51 +0300 From: "Kirill A. Shutemov" To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Subject: Re: [PATCH v16 06/22] mm/thp: clean up lru_add_page_tail Message-ID: <20200720084351.v3skr3pluudy6fer@box> References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> X-Rspamd-Queue-Id: 0F6B3181E3F99 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 11, 2020 at 08:58:40AM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov