From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B15CC433E1 for ; Tue, 21 Jul 2020 05:00:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE04320792 for ; Tue, 21 Jul 2020 05:00:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE04320792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F130F6B0006; Tue, 21 Jul 2020 01:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC2B76B0007; Tue, 21 Jul 2020 01:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD8AB6B0008; Tue, 21 Jul 2020 01:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id C7F836B0006 for ; Tue, 21 Jul 2020 01:00:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5D91AB9E7C81 for ; Tue, 21 Jul 2020 05:00:52 +0000 (UTC) X-FDA: 77060883144.11.sail62_1e0e7e126f2a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 31C9D1803BE88 for ; Tue, 21 Jul 2020 05:00:52 +0000 (UTC) X-HE-Tag: sail62_1e0e7e126f2a X-Filterd-Recvd-Size: 2334 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jul 2020 05:00:51 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 42A716736F; Tue, 21 Jul 2020 07:00:48 +0200 (CEST) Date: Tue, 21 Jul 2020 07:00:47 +0200 From: Christoph Hellwig To: Richard Weinberger Cc: Artem Bityutskiy , Christoph Hellwig , Jens Axboe , linux-raid@vger.kernel.org, Hans de Goede , Richard Weinberger , LKML , linux-block@vger.kernel.org, Song Liu , device-mapper development , linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-fsdevel , cgroups mailinglist , drbd-dev@lists.linbit.com Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init Message-ID: <20200721050047.GA9707@lst.de> References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-5-hch@lst.de> <20200720120734.GA29061@lst.de> <2827a5dbd94bc5c2c1706a6074d9a9a32a590feb.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 31C9D1803BE88 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 20, 2020 at 11:27:57PM +0200, Richard Weinberger wrote: > On Mon, Jul 20, 2020 at 2:37 PM Artem Bityutskiy wrote: > > > > On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote: > > > What about jffs2 and blk2mtd raw block devices? > > I don't worry much about blk2mtd. > > > If my memory serves me correctly JFFS2 did not mind readahead. > > This covers my knowledge too. > I fear enabling readahead on JFFS2 will cause performance issues, this > filesystem > is mostly used on small and slow NOR devices. I'm going to wait for Hans for feedback on vboxsf, but in doubt I'll ust add a prep patch or fold for this one to explicit set ra_pages to 0 with a comment then.