From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3059C433E3 for ; Fri, 24 Jul 2020 09:23:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8217E2063A for ; Fri, 24 Jul 2020 09:23:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TVr8EnME" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8217E2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 096558D0008; Fri, 24 Jul 2020 05:23:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047346B0028; Fri, 24 Jul 2020 05:23:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9E548D0008; Fri, 24 Jul 2020 05:23:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id D43866B0026 for ; Fri, 24 Jul 2020 05:23:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 88BAE18367794 for ; Fri, 24 Jul 2020 09:23:03 +0000 (UTC) X-FDA: 77072430246.12.shoes41_3102b6c26f46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 52CCC180B271E for ; Fri, 24 Jul 2020 09:23:03 +0000 (UTC) X-HE-Tag: shoes41_3102b6c26f46 X-Filterd-Recvd-Size: 4143 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jul 2020 09:23:02 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id q4so3309594edv.13 for ; Fri, 24 Jul 2020 02:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LNGLkZP5D8/u8cZ8++DJl4JEFHoFdXiIn1C5bXtzgAs=; b=TVr8EnMEYkpB0XNbRADjLeg2HaEo67xazjjWxA5VZcA++bSJRceRIQCCczT/6Rdyms PxD8N3rPU0zlDTLl0LiWRrFYiuJ+8lEymThg54tbeP37GA8lo/or9STAos35EffaRkAJ 5SNnbMVtTySpaFcoLrjOjuAWUxUmrWXLb1V4n0Mt+3mppuMNH3pD2zFLmqfIcIs/4Bcn uzAWTs/OYCwd4otci5b8oc2UaPkSA+Wd7CdgIYYKJmt2LOEyIJbt8rH66v1Awm/Gm8Bf KXQdXz7kBRGTdb/n5IiRWZnltOlcihVclXxs5yiTe6tr/TehnCANlzulMrpSvZ1g6bDJ CChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=LNGLkZP5D8/u8cZ8++DJl4JEFHoFdXiIn1C5bXtzgAs=; b=iQydQTgtixMuaVQvNKemFM1xPAV6BniK0MvlvNv6FWs6/HAx4lRmHNZ9h2/WiUw4yA mmV5iCA3DRKmkAHXt7xzDjDnmXNxX15A7RuRalUadbt/8UaWkvw+FUVvIJdX/NchulWX mX2BLTq5pWICoTvSC/i5IXRDX261AA0pWG+47bIhoqT/sHSpjf8FEquSd7LLanljDxnS qwowQUVadNAix39EwiAaLJAlWh0zcktiAmCsBWHahw/1ZTsY1wzXd0KbBF4VeHbyX7PU R0W4JRod/rTNt6uEnT3duQaYLb4GAo58RdvMZgjU6Ki+kqFRfAdze3oynfhcE9AsC/n9 Ex0g== X-Gm-Message-State: AOAM533hfqxHFrYaFIqqRwBS52yoJS/MAxTl6gBWfjYSRUvm6gIzKo00 E3lPsMu2mJXZs9HZLcsL8aM= X-Google-Smtp-Source: ABdhPJyWsapp3jdS9V13rZnwZ7bt/j9qOk6Yb8QWM32MEAIMsYVZRyrJGN0IyC3c8uZfYWUPSH/StA== X-Received: by 2002:a05:6402:32b:: with SMTP id q11mr6140414edw.67.1595582581687; Fri, 24 Jul 2020 02:23:01 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id d23sm287994ejj.74.2020.07.24.02.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 02:23:01 -0700 (PDT) Date: Fri, 24 Jul 2020 11:22:58 +0200 From: Ingo Molnar To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Masami Hiramatsu , Andi Kleen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , "Paul E. McKenney" , Marco Elver , Babu Moger , Brian Gerst , Nayna Jain Subject: Re: [PATCH v5 3/6] arch/x86: Implement text_alloc() and text_free() Message-ID: <20200724092258.GC517988@gmail.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-4-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724050553.1724168-4-jarkko.sakkinen@linux.intel.com> X-Rspamd-Queue-Id: 52CCC180B271E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Jarkko Sakkinen wrote: > +void text_free(void *region) > +{ > + /* > + * This memory may be RO, and freeing RO memory in an interrupt is not > + * supported by vmalloc. > + */ > + lockdep_assert_irqs_enabled(); > + > + vfree(region); Had to dig around a bit to find the source of this restriction. Might make sense to clarify this comment to: /* * This memory may be read-only, and freeing VM_FLUSH_RESET_PERMS memory * in an interrupt is not supported by vmalloc. */ Thanks, Ingo