From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FF2C433E0 for ; Sat, 25 Jul 2020 02:36:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99D35206C1 for ; Sat, 25 Jul 2020 02:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99D35206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C58C88D0003; Fri, 24 Jul 2020 22:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C09B78D0002; Fri, 24 Jul 2020 22:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1508D0003; Fri, 24 Jul 2020 22:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 94BBF8D0002 for ; Fri, 24 Jul 2020 22:36:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3A79C18034AD7 for ; Sat, 25 Jul 2020 02:36:43 +0000 (UTC) X-FDA: 77075035086.23.straw69_131377e26f4c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 13CE62514C for ; Sat, 25 Jul 2020 02:36:43 +0000 (UTC) X-HE-Tag: straw69_131377e26f4c X-Filterd-Recvd-Size: 4383 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 02:36:42 +0000 (UTC) IronPort-SDR: yT88aCc6yYgKnTtoSxmLm6nqxDig6/iwGeURErzjAc3migXxP7lXzF5B1GKZfwDC+GaXpw7iPu PCYhl+6qN/fw== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="149993303" X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="149993303" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 19:36:40 -0700 IronPort-SDR: KUDOuRXU7WxsPpfpzLDg/dH8nvZCth3M2Ujrp7RGQEKup3WlQurm5AhhZzT75HE6n+bZP1b7PH xU8ocz+diU4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="311607313" Received: from jcrametz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.73]) by fmsmga004.fm.intel.com with ESMTP; 24 Jul 2020 19:36:35 -0700 Date: Sat, 25 Jul 2020 05:36:33 +0300 From: Jarkko Sakkinen To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Peter Zijlstra , Masami Hiramatsu , Jessica Yu , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Steven Rostedt , Ingo Molnar Subject: Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Message-ID: <20200725023633.GC17052@linux.intel.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-2-jarkko.sakkinen@linux.intel.com> <20200724091319.GA517988@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724091319.GA517988@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 13CE62514C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 24, 2020 at 11:13:19AM +0200, Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > > in order to remove the compile time dependency to it. > > > > Cc: linux-mm@kvack.org > > Cc: Andi Kleen > > Cc: Peter Zijlstra > > Suggested-by: Masami Hiramatsu > > Signed-off-by: Jarkko Sakkinen > > --- > > include/linux/module.h | 18 ++++++++++++++++++ > > kernel/kprobes.c | 4 ++-- > > kernel/trace/trace_kprobe.c | 4 ++-- > > 3 files changed, 22 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/module.h b/include/linux/module.h > > index 2e6670860d27..8850b9692b8f 100644 > > --- a/include/linux/module.h > > +++ b/include/linux/module.h > > @@ -705,6 +705,16 @@ static inline bool is_livepatch_module(struct module *mod) > > bool is_module_sig_enforced(void); > > void set_module_sig_enforced(void); > > > > +static inline void lock_modules(void) > > +{ > > + mutex_lock(&module_mutex); > > +} > > + > > +static inline void unlock_modules(void) > > +{ > > + mutex_unlock(&module_mutex); > > +} > > + > > #else /* !CONFIG_MODULES... */ > > > > static inline struct module *__module_address(unsigned long addr) > > @@ -852,6 +862,14 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr) > > return ptr; > > } > > > > +static inline void lock_modules(void) > > +{ > > +} > > + > > +static inline void unlock_modules(void) > > +{ > > +} > > Minor namespace nit: when introducing new locking wrappers please > standardize on the XYZ_lock()/XYZ_unlock() nomenclature, i.e.: > > modules_lock() > ... > modules_unlock() > > Similarly to the mutex_lock/unlock(&module_mutex) API that it is > wrapping. > > Also, JFYI, the overwhelming majority of the modules related APIs use > module_*(), i.e. singular - not plural, so > module_lock()/module_unlock() would be the more canonical choice. > (But both sound fine to me) Thanks, I renamed them as module_lock() and module_unlock(). > Thanks, > > Ingo /Jarkko