From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1587FC433E3 for ; Sat, 25 Jul 2020 02:48:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D8227206C1 for ; Sat, 25 Jul 2020 02:48:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8227206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E6F16B002A; Fri, 24 Jul 2020 22:48:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7975D6B002B; Fri, 24 Jul 2020 22:48:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 687528D0002; Fri, 24 Jul 2020 22:48:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 526216B002A for ; Fri, 24 Jul 2020 22:48:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 13F42182067C7 for ; Sat, 25 Jul 2020 02:48:43 +0000 (UTC) X-FDA: 77075065326.04.spade84_34044a226f4c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id E54C7801724C for ; Sat, 25 Jul 2020 02:48:42 +0000 (UTC) X-HE-Tag: spade84_34044a226f4c X-Filterd-Recvd-Size: 2916 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 02:48:42 +0000 (UTC) IronPort-SDR: l1ZhVLWBuxabOlGyfGOhgwG4TKK0o4gYN6uA6d+HrSTgMqSRpHj7YDy3scFpJf8UHap88iDYeH mGo4wJdbAPXQ== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="138862408" X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="138862408" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 19:48:41 -0700 IronPort-SDR: fzqS3eLZLAAO3Tug8va7oJq1zLXSeJ8KCeB1kRH1CBPIHN4j/QCtgtzobUGR5h7sifonFMs3XN sgIH0Tmhnl5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="329100321" Received: from jcrametz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.73]) by orsmga007.jf.intel.com with ESMTP; 24 Jul 2020 19:48:36 -0700 Date: Sat, 25 Jul 2020 05:48:34 +0300 From: Jarkko Sakkinen To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Peter Zijlstra , Jessica Yu , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Steven Rostedt , Ingo Molnar Subject: Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Message-ID: <20200725024834.GE17052@linux.intel.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-2-jarkko.sakkinen@linux.intel.com> <20200724234631.40f4ffec6adae57ac3df8ea3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724234631.40f4ffec6adae57ac3df8ea3@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: E54C7801724C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 24, 2020 at 11:46:31PM +0900, Masami Hiramatsu wrote: > On Fri, 24 Jul 2020 08:05:48 +0300 > Jarkko Sakkinen wrote: > > > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > > in order to remove the compile time dependency to it. > > This subject is a bit confusing. This is just wrapping modules_mutex in > kpprobes. We still have compile time dependency, e.g. module_state, right? Yes. This more like a preliminary change to make that happen. The actual flagging is in 6/6 ("Remove CONFIG_MODULE dependency"). Maybe a better angle would be to make this update all sites that deal with module_mutex [*] and base the whole rationale on that? [*] https://lore.kernel.org/lkml/20200725024227.GD17052@linux.intel.com/ /Jarkko