From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBF9C433E4 for ; Mon, 27 Jul 2020 12:04:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EDECD20714 for ; Mon, 27 Jul 2020 12:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RcvyZM8o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDECD20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FE4E6B0002; Mon, 27 Jul 2020 08:03:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AE046B0003; Mon, 27 Jul 2020 08:03:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5757D6B0005; Mon, 27 Jul 2020 08:03:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 3D72D6B0002 for ; Mon, 27 Jul 2020 08:03:59 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DF817181AC9BF for ; Mon, 27 Jul 2020 12:03:58 +0000 (UTC) X-FDA: 77083722156.25.tin77_410af8726f61 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 3A7E21804EE2F for ; Mon, 27 Jul 2020 12:03:29 +0000 (UTC) X-HE-Tag: tin77_410af8726f61 X-Filterd-Recvd-Size: 8298 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jul 2020 12:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YYDAeaKa4t/sO3n4UaLOXKVO5eJx6cBV3X1O1+WLrX4=; b=RcvyZM8oyQX0TeQIjDDZ2G0Z3P i+Y/FDbDCqBDLlGR0hT0JjhneQfdMwGjZJRuI2gBoRyfho+lK99X2JhmaRirbgWv7oq20AJTuZ3I4 rnWwhwTqvePIwy8ML0NBxgk8u1bdSX3ZoQGOTi1oxSWHhFQ5jKKWdn+r4IArTg5ulIdSiLNQx9W6C 8xC54wSRDALGHxrlfgL9OhzUuUa0+vCuCmKKoWeWpiTP2mBCSj3eP/EY2K4jrCbZN24qtyO6ibeXI szwpPR7Vmxp1uPfp04A202vD4JMplVt+bZuZ2RrpwBZWQ6fJGrJtHmUa9W4iYL7KyI000wYzKxiSo cIA/8rQA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k01qY-0005oy-Jy; Mon, 27 Jul 2020 12:03:11 +0000 Date: Mon, 27 Jul 2020 13:03:10 +0100 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Hillf Danton , "Kirill A. Shutemov" , Andrew Morton , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Mike Kravetz , Johannes Weiner , Jens Axboe , Markus Elfring Subject: Re: kernel BUG at include/linux/swapops.h:LINE! Message-ID: <20200727120310.GJ23808@casper.infradead.org> References: <000000000000bc4fd705a6e090e2@google.com> <0000000000004c38cd05aad1d13f@google.com> <20200720165144.93189f7825bd28e234a42cb8@linux-foundation.org> <20200723073744.5268-1-hdanton@sina.com> <20200724111311.rcjqigtjqpkenxg6@box> <20200726164904.GG23808@casper.infradead.org> <20200727103140.xycdx6ctecomqsoe@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727103140.xycdx6ctecomqsoe@box> X-Rspamd-Queue-Id: 3A7E21804EE2F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 27, 2020 at 01:31:40PM +0300, Kirill A. Shutemov wrote: > On Sun, Jul 26, 2020 at 05:49:04PM +0100, Matthew Wilcox wrote: > > On Fri, Jul 24, 2020 at 02:13:11PM +0300, Kirill A. Shutemov wrote: > > > On Thu, Jul 23, 2020 at 03:37:44PM +0800, Hillf Danton wrote: > > > > > > > > On Tue, 21 Jul 2020 14:11:31 +0300 Kirill A. Shutemov wrote: > > > > > On Mon, Jul 20, 2020 at 04:51:44PM -0700, Andrew Morton wrote: > > > > > > On Sun, 19 Jul 2020 14:10:19 -0700 syzbot wrote: > > > > > > > > > > > > > syzbot has found a reproducer for the following issue on: > > > > > > > > > > > > > > HEAD commit: 4c43049f Add linux-next specific files for 20200716 > > > > > > > git tree: linux-next > > > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=12c56087100000 > > > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=2c76d72659687242 > > > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=c48f34012b06c4ac67dd > > > > > > > compiler: gcc (GCC) 10.1.0-syz 20200507 > > > > > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1344abeb100000 > > > > > > > > > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > > > > > Reported-by: syzbot+c48f34012b06c4ac67dd@syzkaller.appspotmail.com > > > > > > > > > > > > Thanks. > > > > > > > > > > > > __handle_mm_fault > > > > > > ->pmd_migration_entry_wait > > > > > > ->migration_entry_to_page > > > > > > > > > > > > stumbled onto an unlocked page. > > > > > > > > > > > > I don't immediately see a cause. Perhaps Matthew's "THP prep patches", > > > > > > perhaps something else. > > > > > > > > > > > > Is it possible to perform a bisection? > > > > > > > > > > Maybe it's related to the new lock_page_async()? > > > > > > > > Or is there likely the window that after copy_huge_pmd() the src pmd migrate > > > > entry is removed and the page unlocked but the dst is not? > > > > > > No. > > > > > > copy_huge_pmd() runs with exclusive mmap_lock on the source side and > > > destination side is not running yet. > > > > The one I'm hitting is huge related though. > > > > I added this debug: > > > > +++ b/include/linux/swapops.h > > @@ -165,8 +165,9 @@ static inline struct page *device_private_entry_to_page(swp_entry_t entry) > > #ifdef CONFIG_MIGRATION > > static inline swp_entry_t make_migration_entry(struct page *page, int write) > > { > > - BUG_ON(!PageLocked(compound_head(page))); > > + VM_BUG_ON_PAGE(!PageLocked(page), page); > > > > +if (PageCompound(page)) printk("pfn %lx order %d\n", page_to_pfn(page), thp_order(thp_head(page))); > > return swp_entry(write ? SWP_MIGRATION_WRITE : SWP_MIGRATION_READ, > > page_to_pfn(page)); > > } > > @@ -194,7 +195,11 @@ static inline struct page *migration_entry_to_page(swp_entry_t entry) > > * Any use of migration entries may only occur while the > > * corresponding page is locked > > */ > > - BUG_ON(!PageLocked(compound_head(p))); > > + if (!PageLocked(p)) { > > + dump_page(p, "not locked"); > > + printk("swap entry %d.%lx\n", swp_type(entry), swp_offset(entry)); > > + BUG(); > > + } > > return p; > > } > > > > > > and got useful output (while running generic/086): > > > > 1457 086 (20181): drop_caches: 3 > > 1457 page:00000000a216ae9a refcount:2 mapcount:0 mapping:000000009ba7bfed index:0x2227 pfn:0x229e7 > > 1457 aops:def_blk_aops ino:0 > > 1457 flags: 0x4000000000002030(lru|active|private) > > 1457 raw: 4000000000002030 fffff5b4416b5a48 fffff5b4408a7988 ffff9e9c34848578 > > 1457 raw: 0000000000002227 ffff9e9bd18f0d00 00000002ffffffff 0000000000000000 > > 1457 page dumped because: not locked > > 1457 swap entry 30.229e7 > > 1457 ------------[ cut here ]------------ > > 1457 kernel BUG at include/linux/swapops.h:201! > > 1457 invalid opcode: 0000 [#1] SMP PTI > > 1457 CPU: 3 PID: 646 Comm: check Kdump: loaded Tainted: G W 5.8.0-rc6-00067-gd8b18bdf9870-dirty #355 > > 1457 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1 04/01/2014 > > 1457 RIP: 0010:__migration_entry_wait+0x109/0x110 > > [...] > > > > Looking back in the trace, I see: > > > > ... > > 1457 pfn 229e5 order 9 > > 1457 pfn 229e6 order 9 > > 1457 pfn 229e7 order 9 > > 1457 pfn 229e8 order 9 > > 1457 pfn 229e9 order 9 > > ... > > > > so I would say we have a refcount problem. I've probably made it worse by > > creating more THPs, but I don't think I'm the originator of the problem. > > > > I know very little about the migration code today. I suspect I'm going > > to have to learn about it next week. > > It would be interesting to know if the migration entires ever got removed > for pfn. I mean if remove_migration_pte() got called for it. > > It can be rmap issue too. Maybe it misses PMD on remove_migration_ptes() > or something. It's not mapped with a PMD. I tweaked my debugging slightly: static inline swp_entry_t make_migration_entry(struct page *page, int write) { - BUG_ON(!PageLocked(compound_head(page))); + VM_BUG_ON_PAGE(!PageLocked(page), page); +if (PageHead(page)) dump_page(page, "make entry"); +if (PageTail(page)) printk("pfn %lx order %d\n", page_to_pfn(page), thp_order(thp_head(page))); 1523 page:0000000006f62206 refcount:490 mapcount:1 mapping:0000000000000000 index:0x562b12a00 pfn:0x1dc00 1523 head:0000000006f62206 order:9 compound_mapcount:0 compound_pincount:0 1523 anon flags: 0x400000000009003d(locked|uptodate|dirty|lru|active|head|swapbacked) 1523 raw: 400000000009003d ffffecfd41301308 ffffecfd41b08008 ffff9e9971c00059 1523 raw: 0000000562b12a00 0000000000000000 000001ea00000000 0000000000000000 1523 page dumped because: make entry 1523 pfn 1dc01 order 9 1523 pfn 1dc02 order 9 1523 pfn 1dc03 order 9 ... Notice that it's an anonymous page, so it's not related to my work.