From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1A3C433E3 for ; Tue, 28 Jul 2020 21:55:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F47B206D4 for ; Tue, 28 Jul 2020 21:55:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l5YXwP19" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F47B206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3671A8D0007; Tue, 28 Jul 2020 17:55:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 318B28D0002; Tue, 28 Jul 2020 17:55:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22E258D0007; Tue, 28 Jul 2020 17:55:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 0C7B28D0002 for ; Tue, 28 Jul 2020 17:55:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8D1AB181AC9C6 for ; Tue, 28 Jul 2020 21:55:56 +0000 (UTC) X-FDA: 77088842712.06.fuel75_2a10dc026f6d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 602D81003B4B5 for ; Tue, 28 Jul 2020 21:55:56 +0000 (UTC) X-HE-Tag: fuel75_2a10dc026f6d X-Filterd-Recvd-Size: 3591 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jul 2020 21:55:55 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6375B206D4; Tue, 28 Jul 2020 21:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595973354; bh=iHwgETSwMYC9wiqhA4AumxvqL8yv08TTtqWNcMzlamY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l5YXwP19L5ctPXEi1iX/s1kox20cdAYURxF6KpqQbK6OL8B3WbykWVyTkErlUU2Vo Ubvm25JXVritJ23Cwg+aAHPIOva1RDwH5kFTi3I0c+gkJxvEbm1HFOntpi/yyyMdLZ JMAs8GZQKyw/ozzB/WKOqJ+pHwkHkw/uHnTzNqV8= Date: Tue, 28 Jul 2020 14:55:53 -0700 From: Andrew Morton To: Randy Dunlap Cc: broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: mmotm 2020-07-27-18-18 uploaded (mm/page_alloc.c) Message-Id: <20200728145553.2a69fa2080de01922b3a74e0@linux-foundation.org> In-Reply-To: References: <20200728011914.S-8vAYUK0%akpm@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 602D81003B4B5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 28 Jul 2020 05:33:58 -0700 Randy Dunlap w= rote: > On 7/27/20 6:19 PM, Andrew Morton wrote: > > The mm-of-the-moment snapshot 2020-07-27-18-18 has been uploaded to > >=20 > > http://www.ozlabs.org/~akpm/mmotm/ > >=20 > > mmotm-readme.txt says > >=20 > > README for mm-of-the-moment: > >=20 > > http://www.ozlabs.org/~akpm/mmotm/ > >=20 > > This is a snapshot of my -mm patch queue. Uploaded at random hopeful= ly > > more than once a week. > >=20 > > You will need quilt to apply these patches to the latest Linus releas= e (5.x > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicat= ed in > > http://ozlabs.org/~akpm/mmotm/series > >=20 >=20 > on x86_64: >=20 > ../mm/page_alloc.c:8355:48: warning: =E2=80=98struct compact_control=E2= =80=99 declared inside parameter list will not be visible outside of this= definition or declaration > static int __alloc_contig_migrate_range(struct compact_control *cc, > ^~~~~~~~~~~~~~~ As is usually the case with your reports, I can't figure out how to reproduce it. I copy then .config, run `make oldconfig' (need to hit enter a zillion times because the .config is whacky) then the build succeeds. What's the secret? Anyway, #ifdef CONFIG_CONTIG_ALLOC ... /* [start, end) must belong to a single zone. */ static int __alloc_contig_migrate_range(struct compact_control *cc, unsigned long start, unsigned long end) and #if defined CONFIG_COMPACTION || defined CONFIG_CMA ... struct compact_control { so we presumably have CONFIG_CONTIG_ALLOC=3Dy CONFIG_COMPACTION=3Dn CONFIG_CMA=3Dn which is indeed what's in your config file. But config CONTIG_ALLOC def_bool (MEMORY_ISOLATION && COMPACTION) || CMA says this is an improper combination. And `make oldconfig' fixes it up. What's happening here?