Re: [PATCH] mm/dmapool.c: add WARN_ON() in dma_pool_destroy

Matthew Wilcox
2020-07-31T02:39:04Z

On Fri, Jul 31, 2020 at 10:39:39AM +0800, qiang.zhang@windriver.com wrote:
> The pool is being destroyed, all page which in the pool,
> should be free. if some page is still be use by somebody,
> we should not just output error logs, also should also add
> a warning message.

There's already a warning message. What value does this actually have?

> Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
> ---
> mm/dmapool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index f9fb9bbd733e..8f4dc53dde5b 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -285,7 +285,7 @@ void dma_pool_destroy(struct dma_pool *pool)
> struct dma_page *page;
> page = list_entry(pool->page_list.next,
> struct dma_page, page_list);
> - if (is_page_busy(page)) {
> + if (WARN_ON(is_page_busy(page))) {
> if (pool->dev)
> dev_err(pool->dev,
> "dma_pool_destroy %s, %p busy\n",
> --
> 2.26.2
>