From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399EFC433DF for ; Wed, 12 Aug 2020 01:31:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4B412076C for ; Wed, 12 Aug 2020 01:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="im5NYhn8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B412076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8577D8D0002; Tue, 11 Aug 2020 21:31:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E40D8D0001; Tue, 11 Aug 2020 21:31:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FAB16B0032; Tue, 11 Aug 2020 21:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 39CB96B002F for ; Tue, 11 Aug 2020 21:31:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0303A181AEF15 for ; Wed, 12 Aug 2020 01:31:34 +0000 (UTC) X-FDA: 77140189308.26.book68_3f0983226fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id CED831804B670 for ; Wed, 12 Aug 2020 01:31:33 +0000 (UTC) X-HE-Tag: book68_3f0983226fe7 X-Filterd-Recvd-Size: 2761 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:31:33 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D51E206B2; Wed, 12 Aug 2020 01:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597195892; bh=zRGeNM6mpYmWTG1hl4rMZdDYVTJmyd34zKe0DAJKaMs=; h=Date:From:To:Subject:In-Reply-To:From; b=im5NYhn8mml1t0UHky5AzX/Jcxk4JsBxFi92zHdDckqmF8oumNQYbZZ1DqC1VZhf9 asqK9nIt2Cg/aMdaXvRnKGfeqOH6c/HlpDOx/Bkbs2c8sk8/IhdBnXodidAegtU1J9 2K71y1Q8I2LV+i2Vq2W9ve8PunaBLCij6SdPLT34= Date: Tue, 11 Aug 2020 18:31:32 -0700 From: Andrew Morton To: akpm@linux-foundation.org, cai@lca.pw, laoar.shao@gmail.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, penguin-kernel@i-love.sakura.ne.jp, rientjes@google.com, torvalds@linux-foundation.org Subject: [patch 024/165] mm, oom: show process exiting information in __oom_kill_process() Message-ID: <20200812013132.y2HAP8zOp%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: CED831804B670 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yafang Shao Subject: mm, oom: show process exiting information in __oom_kill_process() When the OOM killer finds a victim and tryies to kill it, if the victim is already exiting, the task mm will be NULL and no process will be killed. But the dump_header() has been already executed, so it will be strange to dump so much information without killing a process. We'd better show some helpful information to indicate why this happens. Link: http://lkml.kernel.org/r/20200721010127.17238-1-laoar.shao@gmail.com Signed-off-by: Yafang Shao Suggested-by: David Rientjes Acked-by: Michal Hocko Cc: Tetsuo Handa Cc: Qian Cai Signed-off-by: Andrew Morton --- mm/oom_kill.c | 2 ++ 1 file changed, 2 insertions(+) --- a/mm/oom_kill.c~mm-oom-show-process-exiting-information-in-__oom_kill_process +++ a/mm/oom_kill.c @@ -861,6 +861,8 @@ static void __oom_kill_process(struct ta p = find_lock_task_mm(victim); if (!p) { + pr_info("%s: OOM victim %d (%s) is already exiting. Skip killing the task\n", + message, task_pid_nr(victim), victim->comm); put_task_struct(victim); return; } else if (victim != p) { _