From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C305C433E1 for ; Wed, 12 Aug 2020 01:34:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED228206B2 for ; Wed, 12 Aug 2020 01:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IH+6Vu/u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED228206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9902D8D0048; Tue, 11 Aug 2020 21:34:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 918568D0001; Tue, 11 Aug 2020 21:34:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82E518D0048; Tue, 11 Aug 2020 21:34:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 64ECD8D0001 for ; Tue, 11 Aug 2020 21:34:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 310A0180AD807 for ; Wed, 12 Aug 2020 01:34:37 +0000 (UTC) X-FDA: 77140196994.05.plant04_19063a226fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 07E4A1826B6A6 for ; Wed, 12 Aug 2020 01:34:37 +0000 (UTC) X-HE-Tag: plant04_19063a226fe7 X-Filterd-Recvd-Size: 2624 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:34:36 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BE57206B2; Wed, 12 Aug 2020 01:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597196075; bh=7yK4909hmiGXHPAljXzByNcfIcJarOUX4q5zZhY8Pgs=; h=Date:From:To:Subject:In-Reply-To:From; b=IH+6Vu/uUd09SChdHVYKQPtKBrZyh1K4gA8LSF0nn4eVXpFLqbdS/pX5GVDHvz2dc frBN0vMG7J/rZ86csg4k8uGBLW74bcy4dYOuTeuGNk1xj2zNZWZpyyUkZLMDU9HFXr zEOz6Y8+gmMFCj0MpuvVbiL9WMakQRnN8k4EuRHc= Date: Tue, 11 Aug 2020 18:34:35 -0700 From: Andrew Morton To: akpm@linux-foundation.org, kent.overstreet@gmail.com, linux-mm@kvack.org, luc.vanoostenryck@gmail.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 082/165] lib/generic-radix-tree.c: remove unneeded __rcu Message-ID: <20200812013435.qn4uVoFuk%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 07E4A1826B6A6 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Luc Van Oostenryck Subject: lib/generic-radix-tree.c: remove unneeded __rcu struct __genradix is defined as having its member 'root' annotated as __rcu. But in the corresponding API RCU is not used. Sparse reports this type mismatch as: lib/generic-radix-tree.c:56:35: warning: incorrect type in initializer (different address spaces) lib/generic-radix-tree.c:56:35: expected struct genradix_root *r lib/generic-radix-tree.c:56:35: got struct genradix_root [noderef] *__val with 6 other ones. So, correct root's type by removing this unneeded __rcu. Link: http://lkml.kernel.org/r/20200621161745.55396-1-luc.vanoostenryck@gmail.com Signed-off-by: Luc Van Oostenryck Cc: Kent Overstreet Signed-off-by: Andrew Morton --- include/linux/generic-radix-tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/generic-radix-tree.h~lib-generic-radix-treec-remove-unneeded-__rcu +++ a/include/linux/generic-radix-tree.h @@ -44,7 +44,7 @@ struct genradix_root; struct __genradix { - struct genradix_root __rcu *root; + struct genradix_root *root; }; /* _