From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894FBC433E3 for ; Wed, 12 Aug 2020 01:35:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DB9020658 for ; Wed, 12 Aug 2020 01:35:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TivqLMkQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB9020658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CCAF8D0061; Tue, 11 Aug 2020 21:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 854948D0001; Tue, 11 Aug 2020 21:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F59D8D0061; Tue, 11 Aug 2020 21:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 51C608D0001 for ; Tue, 11 Aug 2020 21:35:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 169CF364E for ; Wed, 12 Aug 2020 01:35:55 +0000 (UTC) X-FDA: 77140200270.08.ear28_4900b0026fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id E16A01819E764 for ; Wed, 12 Aug 2020 01:35:54 +0000 (UTC) X-HE-Tag: ear28_4900b0026fe7 X-Filterd-Recvd-Size: 2694 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:35:54 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E57E20678; Wed, 12 Aug 2020 01:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597196153; bh=nPoAqheCqAfE7zofJMHKydcnqm0FHA43D6tjw6sFYGM=; h=Date:From:To:Subject:In-Reply-To:From; b=TivqLMkQJcQa9flCNgaHLdFg+XTfzxe851YCmUNpfTNoW5EhNwIfiUDvheXDuannv qxSRpoJw4yN0Rodv+zC4iae9lkyn44a95yi5Hrfr4RYgWvQtqHlILwOruk2xonrpCT CltJQ4FDWuFAqfHaHbT2xbxhLiO5aZOclTYG+6yk= Date: Tue, 11 Aug 2020 18:35:53 -0700 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, colin.king@canonical.com, dushistov@mail.ru, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 107/165] fs/ufs: avoid potential u32 multiplication overflow Message-ID: <20200812013553.jHLcfo7PH%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: E16A01819E764 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Colin Ian King Subject: fs/ufs: avoid potential u32 multiplication overflow The 64 bit ino is being compared to the product of two u32 values, however, the multiplication is being performed using a 32 bit multiply so there is a potential of an overflow. To be fully safe, cast uspi->s_ncg to a u64 to ensure a 64 bit multiplication occurs to avoid any chance of overflow. Addresses-Coverity: ("Unintentional integer overflow") Link: http://lkml.kernel.org/r/20200715170355.1081713-1-colin.king@canonical.com Fixes: f3e2a520f5fb ("ufs: NFS support") Signed-off-by: Colin Ian King Cc: Evgeniy Dushistov Cc: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/ufs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ufs/super.c~fs-ufs-avoid-potential-u32-multiplication-overflow +++ a/fs/ufs/super.c @@ -101,7 +101,7 @@ static struct inode *ufs_nfs_get_inode(s struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi; struct inode *inode; - if (ino < UFS_ROOTINO || ino > uspi->s_ncg * uspi->s_ipg) + if (ino < UFS_ROOTINO || ino > (u64)uspi->s_ncg * uspi->s_ipg) return ERR_PTR(-ESTALE); inode = ufs_iget(sb, ino); _