From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C4B3C433E1 for ; Wed, 12 Aug 2020 01:36:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0ED22054F for ; Wed, 12 Aug 2020 01:36:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cL2eIYCt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0ED22054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 745548D0068; Tue, 11 Aug 2020 21:36:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71B2B8D0001; Tue, 11 Aug 2020 21:36:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658F68D0068; Tue, 11 Aug 2020 21:36:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 4FBE28D0001 for ; Tue, 11 Aug 2020 21:36:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1E02C52D0 for ; Wed, 12 Aug 2020 01:36:19 +0000 (UTC) X-FDA: 77140201278.17.hill18_1f0b36b26fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id E382F180D0181 for ; Wed, 12 Aug 2020 01:36:18 +0000 (UTC) X-HE-Tag: hill18_1f0b36b26fe7 X-Filterd-Recvd-Size: 4130 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:36:18 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 752F020678; Wed, 12 Aug 2020 01:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597196177; bh=OXkFYqDQrDZwLwkEZLN2oq/Qe37Bh9l2JW/wnnhYcp0=; h=Date:From:To:Subject:In-Reply-To:From; b=cL2eIYCtY+fPMamgj8wEfIfNrdFRl22tOF+pVACX+9tXWfVPr082t4lhVL9z/zHuZ 0ryBZ6ADik9QVjsMeq9/vL8nqTwi0qe5G0ycx7PPu34eR2XXjgcc7pDSW0HTpLYGY8 tdliaPJPEgpPK4RozHfg3VlRxaSV4DxFQZoCU4Eo= Date: Tue, 11 Aug 2020 18:36:16 -0700 From: Andrew Morton To: akpm@linux-foundation.org, ast@kernel.org, axboe@kernel.dk, bfields@fieldses.org, chainsaw@gentoo.org, christian.brauner@ubuntu.com, chuck.lever@oracle.com, davem@davemloft.net, dhowells@redhat.com, gregkh@linuxfoundation.org, hch@infradead.org, jarkko.sakkinen@linux.intel.com, jmorris@namei.org, josh@joshtriplett.org, keescook@chromium.org, kuba@kernel.org, lars.ellenberg@linbit.com, linux-mm@kvack.org, mcgrof@kernel.org, mm-commits@vger.kernel.org, nikolay@cumulusnetworks.com, philipp.reisner@linbit.com, ravenexp@gmail.com, roopa@cumulusnetworks.com, serge@hallyn.com, shuah@kernel.org, slyfox@gentoo.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, yangtiezhu@loongson.cn Subject: [patch 114/165] test_kmod: avoid potential double free in trigger_config_run_type() Message-ID: <20200812013616.O9SnvlJDt%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: E382F180D0181 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tiezhu Yang Subject: test_kmod: avoid potential double free in trigger_config_run_type() Reset the member "test_fs" of the test configuration after a call of the function "kfree_const" to a null pointer so that a double memory release will not be performed. Link: http://lkml.kernel.org/r/20200610154923.27510-4-mcgrof@kernel.org Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader") Signed-off-by: Tiezhu Yang Signed-off-by: Luis Chamberlain Acked-by: Luis Chamberlain Cc: Alexei Starovoitov Cc: Al Viro Cc: Christian Brauner Cc: Chuck Lever Cc: David Howells Cc: David S. Miller Cc: Greg Kroah-Hartman Cc: Jakub Kicinski Cc: James Morris Cc: Jarkko Sakkinen Cc: J. Bruce Fields Cc: Jens Axboe Cc: Josh Triplett Cc: Kees Cook Cc: Lars Ellenberg Cc: Nikolay Aleksandrov Cc: Philipp Reisner Cc: Roopa Prabhu Cc: "Serge E. Hallyn" Cc: Sergei Trofimovich Cc: Sergey Kvachonok Cc: Shuah Khan Cc: Tony Vroon Cc: Christoph Hellwig Signed-off-by: Andrew Morton --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_kmod.c~test_kmod-avoid-potential-double-free-in-trigger_config_run_type +++ a/lib/test_kmod.c @@ -745,7 +745,7 @@ static int trigger_config_run_type(struc break; case TEST_KMOD_FS_TYPE: kfree_const(config->test_fs); - config->test_driver = NULL; + config->test_fs = NULL; copied = config_copy_test_fs(config, test_str, strlen(test_str)); break; _