linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Roman Gushchin <klamm@yandex-team.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm : update ra->ra_pages if it's NOT equal to bdi->ra_pages
Date: Fri, 14 Aug 2020 02:43:55 +0100	[thread overview]
Message-ID: <20200814014355.GS17456@casper.infradead.org> (raw)
In-Reply-To: <1597368611-7631-1-git-send-email-zhaoyang.huang@unisoc.com>

On Fri, Aug 14, 2020 at 09:30:11AM +0800, Zhaoyang Huang wrote:
> file->f_ra->ra_pages will remain the initialized value since it opend, which may
> be NOT equal to bdi->ra_pages as the latter one is updated somehow(etc,
> echo xxx > /sys/block/dm/queue/read_ahead_kb).So sync ra->ra_pages to the
> updated value when sync read.

It still ignores the work done by shrink_readahead_size_eio()
and fadvise(POSIX_FADV_SEQUENTIAL).


  reply	other threads:[~2020-08-14  1:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  1:30 [PATCH] mm : update ra->ra_pages if it's NOT equal to bdi->ra_pages Zhaoyang Huang
2020-08-14  1:43 ` Matthew Wilcox [this message]
2020-08-14  2:07   ` Matthew Wilcox
2020-08-14  2:20     ` Zhaoyang Huang
2020-08-14  2:26       ` Zhaoyang Huang
2020-08-14  2:31         ` Matthew Wilcox
2020-08-14  2:33       ` Andrew Morton
2020-08-14  2:45         ` Zhaoyang Huang
2020-08-14  3:19           ` Matthew Wilcox
2020-08-14 22:17             ` Minchan Kim
2020-08-14 17:46         ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814014355.GS17456@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=huangzhaoyang@gmail.com \
    --cc=klamm@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).