From: Oleg Nesterov <oleg@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Song Liu <songliubraving@fb.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] uprobes: __replace_page() avoid BUG in munlock_vma_page()
Date: Mon, 17 Aug 2020 16:07:45 +0200 [thread overview]
Message-ID: <20200817140744.GC29865@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2008161338360.20413@eggly.anvils>
On 08/16, Hugh Dickins wrote:
>
> --- v5.9-rc/kernel/events/uprobes.c 2020-08-12 19:46:50.851196584 -0700
> +++ linux/kernel/events/uprobes.c 2020-08-16 13:18:35.292821674 -0700
> @@ -205,7 +205,7 @@ static int __replace_page(struct vm_area
> try_to_free_swap(old_page);
> page_vma_mapped_walk_done(&pvmw);
>
> - if (vma->vm_flags & VM_LOCKED)
> + if ((vma->vm_flags & VM_LOCKED) && !PageCompound(old_page))
> munlock_vma_page(old_page);
> put_page(old_page);
Thanks!
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2020-08-17 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 20:44 [PATCH] uprobes: __replace_page() avoid BUG in munlock_vma_page() Hugh Dickins
2020-08-17 5:43 ` Song Liu
2020-08-17 7:17 ` Hugh Dickins
2020-08-17 16:06 ` Song Liu
2020-08-17 14:07 ` Oleg Nesterov [this message]
2020-08-17 14:40 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817140744.GC29865@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songliubraving@fb.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).