From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285BBC433DF for ; Tue, 18 Aug 2020 11:52:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E190F207D3 for ; Tue, 18 Aug 2020 11:51:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EdiKSbZj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E190F207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 744BF6B000D; Tue, 18 Aug 2020 07:51:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F47F6B0010; Tue, 18 Aug 2020 07:51:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60AEA6B0022; Tue, 18 Aug 2020 07:51:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 491F96B000D for ; Tue, 18 Aug 2020 07:51:59 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F4147824556B for ; Tue, 18 Aug 2020 11:51:58 +0000 (UTC) X-FDA: 77163525558.28.glass53_4005a782701f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id C0DE16C1D for ; Tue, 18 Aug 2020 11:51:58 +0000 (UTC) X-HE-Tag: glass53_4005a782701f X-Filterd-Recvd-Size: 4149 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 11:51:58 +0000 (UTC) Received: from kernel.org (unknown [87.70.91.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 034932075E; Tue, 18 Aug 2020 11:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597751517; bh=V6zWYb60MNl5LiY+q8W9QZ7ZvQ5dlxEVJ0ia/eFZhOc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EdiKSbZj6yupVmUP+5fgsTfrtgHsXTtYGQPZhK0G3omTz9/YKqeHIIHQLPBMHEdSQ 5dKAsH8xPi+rdLUQW0npUmLUMS/ryx/nh+pzlI+uc3OpzrNKpOL0XN8SoaoezTn7B8 cgbqmLJSwKXwQfA9Xib/PN269LIn3jo72JuPsQJk= Date: Tue, 18 Aug 2020 14:51:41 +0300 From: Mike Rapoport To: Jarkko Sakkinen Cc: Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Masami Hiramatsu , Peter Zijlstra , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Jessica Yu , Ard Biesheuvel Subject: Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free() Message-ID: <20200818115141.GO752365@kernel.org> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-6-jarkko.sakkinen@linux.intel.com> <20200724092746.GD517988@gmail.com> <20200725031648.GG17052@linux.intel.com> <20200726081408.GB2927915@kernel.org> <20200818053029.GE44714@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818053029.GE44714@linux.intel.com> X-Rspamd-Queue-Id: C0DE16C1D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > I'm not still sure that I fully understand this feedback as I don't see > > > any inherent and obvious difference to the v4. In that version fallbacks > > > are to module_alloc() and module_memfree() and text_alloc() and > > > text_memfree() can be overridden by arch. > > > > The major difference between your v4 and my suggestion is that I'm not > > trying to impose a single ARCH_HAS_TEXT_ALLOC as an alternative to > > MODULES but rather to use per subsystem config option, e.g. > > HAVE_KPROBES_TEXT_ALLOC. > > > > Another thing, which might be worth doing regardless of the outcome of > > this discussion is to rename alloc_insn_pages() to text_alloc_kprobes() > > because the former is way too generic and does not emphasize that the > > instruction page is actually used by kprobes only. > > What if we in kernel/kprobes.c just: > > #ifndef CONFIG_ARCH_HAS_TEXT_ALLOC I don't think that CONFIG_ARCH_HAS_TEXT_ALLOC will work for all architectures. If an architecture has different restrictions for allocation of text for, say, modules, kprobes, bfp, it won't be able to use a single ARCH_HAS_TEXT_ALLOC. Which means that this architecture is stuck with dependency of kprobes on MODULES until the next rework. > void __weak *alloc_insn_page(void) > { > return module_alloc(PAGE_SIZE); > } > > void __weak free_insn_page(void *page) > { > module_memfree(page); > } > #endif > > In Kconfig (as in v5): > > config KPROBES > bool "Kprobes" > depends on MODULES || ARCH_HAS_TEXT_ALLOC > > I checked architectures that override alloc_insn_page(). With the > exception of x86, they do not call module_alloc(). > > If no rename was done, then with this approach a more consistent. > config flag name would be CONFIG_ARCH_HAS_ALLOC_INSN_PAGE. > > I'd call the function just as kprobes_alloc_page(). Then the > config flag would become CONFIG_HAS_KPROBES_ALLOC_PAGE. > > > -- > > Sincerely yours, > > Mike. > > Thanks for the feedback! > > /Jarkko -- Sincerely yours, Mike.