From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29D2C433E1 for ; Tue, 25 Aug 2020 10:27:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A14A62068F for ; Tue, 25 Aug 2020 10:27:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Yn/2iVuF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A14A62068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28A216B002B; Tue, 25 Aug 2020 06:27:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 211E16B002D; Tue, 25 Aug 2020 06:27:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B2706B002E; Tue, 25 Aug 2020 06:27:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id E45796B002B for ; Tue, 25 Aug 2020 06:27:56 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A512E181AEF1D for ; Tue, 25 Aug 2020 10:27:56 +0000 (UTC) X-FDA: 77188715352.09.line89_380a8a32705b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 70BA3180AD80F for ; Tue, 25 Aug 2020 10:27:56 +0000 (UTC) X-HE-Tag: line89_380a8a32705b X-Filterd-Recvd-Size: 4857 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 10:27:55 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07PAPFAQ095524; Tue, 25 Aug 2020 10:27:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=b6iegNqLwrRZ7/XgXsM/pskrreM6dy6nNfdi8O6zFu0=; b=Yn/2iVuFRBOI1FrZOk5WhWDIFZAUvbXdfUiVO37hCqQB2rI4NZiOlys8RJAe66adQzQh XnkuyTXJknRSXGbrhwJJn4E8a9Bd29JUYPFgTAL+5qgfialJnSh6XDOmuICN5qr47vAO 8ZdxciW/AdCWEnz8h29Kqv3SevPlV1/dtWES3fJqHmtuoQHHP4elJgFkgS0M8eDyPZr5 7112HRfHJ5+4bXArlvwfj1p2Bl0Nf+dlVFZUZqCcGlKxYfW7CCItGW5wG5MsHsi3uSh7 I7+glmNsmRAAxfPK7r1VK6aydMWPSqheEAeqfkPED3P2F6KHIVybjH9dQPLVDVkLT/gl Uw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 333w6tr6ub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Aug 2020 10:27:54 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07PAKlOx056525; Tue, 25 Aug 2020 10:25:54 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 333rtxmcp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Aug 2020 10:25:53 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07PAPqnS006091; Tue, 25 Aug 2020 10:25:52 GMT Received: from mwanda (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 25 Aug 2020 03:25:52 -0700 Date: Tue, 25 Aug 2020 13:25:46 +0300 From: Dan Carpenter To: osalvador@suse.de Cc: linux-mm@kvack.org Subject: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page Message-ID: <20200825102546.GA272697@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9723 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=907 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008250077 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9723 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 mlxlogscore=880 suspectscore=3 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1011 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008250078 X-Rspamd-Queue-Id: 70BA3180AD80F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Oscar Salvador, The patch e5bcf91e5cc6: "mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page" from Aug 20, 2020, leads to the following static checker warning: mm/memory-failure.c:1765 isolate_page() warn: signedness bug returning '(-16)' mm/memory-failure.c 1749 static bool isolate_page(struct page *page, struct list_head *pagelist) 1750 { 1751 bool isolated = false; 1752 bool lru = PageLRU(page); 1753 1754 if (PageHuge(page)) { 1755 isolated = isolate_huge_page(page, pagelist); 1756 } else { 1757 if (lru) 1758 isolated = !isolate_lru_page(page); 1759 else 1760 isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); 1761 1762 if (isolated) 1763 list_add(&page->lru, pagelist); 1764 1765 return -EBUSY; return false;? 1766 } 1767 1768 if (isolated && lru) 1769 inc_node_page_state(page, NR_ISOLATED_ANON + 1770 page_is_file_lru(page)); 1771 1772 /* 1773 * If we succeed to isolate the page, we grabbed another refcount on 1774 * the page, so we can safely drop the one we got from get_any_pages(). 1775 * If we failed to isolate the page, it means that we cannot go further 1776 * and we will return an error, so drop the reference we got from 1777 * get_any_pages() as well. 1778 */ 1779 put_page(page); 1780 return isolated; 1781 } regards, dan carpenter