From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A5EC433DF for ; Tue, 25 Aug 2020 10:39:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 18F6E20706 for ; Tue, 25 Aug 2020 10:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18F6E20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE9078D0005; Tue, 25 Aug 2020 06:39:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A99236B0037; Tue, 25 Aug 2020 06:39:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AE638D0005; Tue, 25 Aug 2020 06:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 82E0B6B0036 for ; Tue, 25 Aug 2020 06:39:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3D0B4362A for ; Tue, 25 Aug 2020 10:39:26 +0000 (UTC) X-FDA: 77188744332.22.fight85_4e126292705b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 0CEA818038E60 for ; Tue, 25 Aug 2020 10:39:26 +0000 (UTC) X-HE-Tag: fight85_4e126292705b X-Filterd-Recvd-Size: 2255 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 10:39:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 39028B118; Tue, 25 Aug 2020 10:39:55 +0000 (UTC) Date: Tue, 25 Aug 2020 12:39:22 +0200 From: Oscar Salvador To: Dan Carpenter Cc: linux-mm@kvack.org, nao.horiguchi@gmail.com, akpm@linux-foundation.org Subject: Re: [bug report] mm,hwpoison: refactor soft_offline_huge_page and __soft_offline_page Message-ID: <20200825103922.GB18748@linux> References: <20200825102546.GA272697@mwanda> <20200825103513.GA18748@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825103513.GA18748@linux> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 0CEA818038E60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 25, 2020 at 12:35:17PM +0200, Oscar Salvador wrote: > > mm/memory-failure.c > > 1749 static bool isolate_page(struct page *page, struct list_head *pagelist) > > 1750 { > > 1751 bool isolated = false; > > 1752 bool lru = PageLRU(page); > > 1753 > > 1754 if (PageHuge(page)) { > > 1755 isolated = isolate_huge_page(page, pagelist); > > 1756 } else { > > 1757 if (lru) > > 1758 isolated = !isolate_lru_page(page); > > 1759 else > > 1760 isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); > > 1761 > > 1762 if (isolated) > > 1763 list_add(&page->lru, pagelist); > > 1764 > > 1765 return -EBUSY; > > > > return false;? > > No, I this is a mistake, I guess it popped there when Naoya rebased. > > That return -EBUSY should be go. > I'll let Andrew know, thanks. Unless I'm blind, it seems it wasn't Naoya's mistake either [1] @Andrew, any idea what happened here? That "return -EBUSY" should not be there. [1] https://patchwork.kernel.org/patch/11704101/ -- Oscar Salvador SUSE L3