From: Roman Gushchin <guro@fb.com>
To: <linux-mm@kvack.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
=Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>, <kernel-team@fb.com>,
<linux-kernel@vger.kernel.org>, Roman Gushchin <guro@fb.com>
Subject: [PATCH RFC 2/4] mm: kmem: remove redundant checks from get_obj_cgroup_from_current()
Date: Thu, 27 Aug 2020 10:52:13 -0700 [thread overview]
Message-ID: <20200827175215.319780-3-guro@fb.com> (raw)
In-Reply-To: <20200827175215.319780-1-guro@fb.com>
There are checks for current->mm and current->active_memcg
in get_obj_cgroup_from_current(), but these checks are redundant:
memcg_kmem_bypass() called just above performs same checks.
Signed-off-by: Roman Gushchin <guro@fb.com>
---
mm/memcontrol.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9c08d8d14bc0..5d847257a639 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2919,9 +2919,6 @@ __always_inline struct obj_cgroup *get_obj_cgroup_from_current(void)
if (memcg_kmem_bypass())
return NULL;
- if (unlikely(!current->mm && !current->active_memcg))
- return NULL;
-
rcu_read_lock();
if (unlikely(current->active_memcg))
memcg = rcu_dereference(current->active_memcg);
--
2.26.2
next prev parent reply other threads:[~2020-08-27 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 17:52 [PATCH RFC 0/4] mm: kmem: kernel memory accounting in an interrupt context Roman Gushchin
2020-08-27 17:52 ` [PATCH RFC 1/4] mm: kmem: move memcg_kmem_bypass() calls to get_mem/obj_cgroup_from_current() Roman Gushchin
2020-08-27 21:10 ` Shakeel Butt
2020-08-27 17:52 ` Roman Gushchin [this message]
2020-08-27 21:10 ` [PATCH RFC 2/4] mm: kmem: remove redundant checks from get_obj_cgroup_from_current() Shakeel Butt
2020-08-27 17:52 ` [PATCH RFC 3/4] mm: kmem: prepare remote memcg charging infra for interrupt contexts Roman Gushchin
2020-08-27 21:58 ` Shakeel Butt
2020-08-27 22:37 ` Roman Gushchin
2020-08-27 17:52 ` [PATCH RFC 4/4] mm: kmem: enable kernel memcg accounting from " Roman Gushchin
2020-08-27 22:02 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827175215.319780-3-guro@fb.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox