From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B01C35265 for ; Fri, 4 Sep 2020 18:10:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C162524836 for ; Fri, 4 Sep 2020 18:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C162524836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B02268E0003; Fri, 4 Sep 2020 13:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB11F8E0001; Fri, 4 Sep 2020 13:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9525F8E0003; Fri, 4 Sep 2020 13:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 76CB38E0001 for ; Fri, 4 Sep 2020 13:30:10 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2A1B4181AC9B6 for ; Fri, 4 Sep 2020 17:30:10 +0000 (UTC) X-FDA: 77226067380.25.quilt56_0d09434270b4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id D8EA61804E3A9 for ; Fri, 4 Sep 2020 17:30:09 +0000 (UTC) X-HE-Tag: quilt56_0d09434270b4 X-Filterd-Recvd-Size: 4227 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 17:30:09 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id c15so7468104wrs.11 for ; Fri, 04 Sep 2020 10:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wNy2hGieTjSAjcYv7kwR0BOvIQ7J3JLWd6JVvNnGJ0g=; b=nrlRQjY8Io138M0I0vEGr+v4Bn08/HBULOCAldPvos7jppGo8f+KS1XDGwsKWDTdX/ +Po2HYB94FsDa8hzuP4FVXhl9qKbhIcL8imzENxA1w9dqWmgVlfwuzj2RGNRWM/HUyxl zbthhuEk2cVOH02N3TKoOdzFVLyJ9k11FbVRz7IMwIJFuGF/5zgjI/LGJZS/li9169yh Q93zg2EW0sHmA/IEB/s/1Ic79KVZU0xYUlYNEk+SoIBDdecAveV4ygbrUH0sNTcqiMQu e8l64HW8B7nDfTrOhSVsQvDPCBU0e/e9VuLQd0zTdUHofRHC9XvV0ws71TJy6e9tQCCH LEJQ== X-Gm-Message-State: AOAM5335g4ajigR6V5UFEE9YUCtEu1i9OlWV0sF58K0wXF7g3W1vvifc Vu+Q8z1ItTCjVS+43i3+uY8= X-Google-Smtp-Source: ABdhPJy4lxSlIVmCZUYUt5G7cHc/b9vzzBbVyS5+h60xbFD5BvIaoh1SmuoljfZVF5ACmqFJVbs98w== X-Received: by 2002:a05:6000:100c:: with SMTP id a12mr9155928wrx.115.1599240608246; Fri, 04 Sep 2020 10:30:08 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id h5sm13026654wrt.31.2020.09.04.10.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 10:30:07 -0700 (PDT) Date: Fri, 4 Sep 2020 17:30:06 +0000 From: Wei Liu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , Michal Hocko , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Pankaj Gupta , Baoquan He , Wei Yang Subject: Re: [PATCH v1 5/5] hv_balloon: try to merge system ram resources Message-ID: <20200904173006.e65qow53ietxzpne@liuwe-devbox-debian-v2> References: <20200821103431.13481-1-david@redhat.com> <20200821103431.13481-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821103431.13481-6-david@redhat.com> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: D8EA61804E3A9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 21, 2020 at 12:34:31PM +0200, David Hildenbrand wrote: > Let's use the new mechanism to merge system ram resources below the > root. We are the only one hotplugging system ram, e.g., DIMMs don't apply, > so this is safe to be used. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: "K. Y. Srinivasan" > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Cc: Wei Liu > Cc: Pankaj Gupta > Cc: Baoquan He > Cc: Wei Yang > Signed-off-by: David Hildenbrand > --- > drivers/hv/hv_balloon.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c > index 32e3bc0aa665a..49a6305f0fb73 100644 > --- a/drivers/hv/hv_balloon.c > +++ b/drivers/hv/hv_balloon.c > @@ -745,6 +745,9 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size, > has->covered_end_pfn -= processed_pfn; > spin_unlock_irqrestore(&dm_device.ha_lock, flags); > break; > + } else { > + /* Try to reduce the number of system ram resources. */ > + merge_system_ram_resources(&iomem_resource); > } You don't need to put the call under the "else" branch. It will have broken out of the loop if ret is not zero. Wei. > > /* > -- > 2.26.2 >