From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE99C43461 for ; Thu, 10 Sep 2020 09:00:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64CBC20795 for ; Thu, 10 Sep 2020 09:00:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64CBC20795 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C9746B005D; Thu, 10 Sep 2020 05:00:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 879CB6B0062; Thu, 10 Sep 2020 05:00:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79052900002; Thu, 10 Sep 2020 05:00:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 628556B005D for ; Thu, 10 Sep 2020 05:00:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 27D4C5DC2 for ; Thu, 10 Sep 2020 09:00:26 +0000 (UTC) X-FDA: 77246555652.18.copy51_3e02c09270e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id D8843100EC66C for ; Thu, 10 Sep 2020 09:00:25 +0000 (UTC) X-HE-Tag: copy51_3e02c09270e4 X-Filterd-Recvd-Size: 1738 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Sep 2020 09:00:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D9011AEC4; Thu, 10 Sep 2020 09:00:39 +0000 (UTC) Date: Thu, 10 Sep 2020 11:00:18 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 2/5] mm, page_alloc: calculate pageset high and batch once per zone Message-ID: <20200910090018.GC2285@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-3-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907163628.26495-3-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: D8843100EC66C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.008269, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 07, 2020 at 06:36:25PM +0200, Vlastimil Babka wrote: > We currently call pageset_set_high_and_batch() for each possible cpu, > which repeats the same calculations of high and batch values. > > Instead call it once per zone, and it applies the calculated values > to all per-cpu pagesets of the zone. > > This also allows removing zone_pageset_init() and __zone_pcp_update() wrappers. > > No functional change. > > Signed-off-by: Vlastimil Babka I like this, it simplifies the things. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3