From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 638B9C43461 for ; Thu, 10 Sep 2020 09:57:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BEA9120882 for ; Thu, 10 Sep 2020 09:57:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA9120882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D18F16B005C; Thu, 10 Sep 2020 05:57:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC7F76B0071; Thu, 10 Sep 2020 05:57:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDF946B0072; Thu, 10 Sep 2020 05:57:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id A731F6B005C for ; Thu, 10 Sep 2020 05:57:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 604DE180AD807 for ; Thu, 10 Sep 2020 09:57:24 +0000 (UTC) X-FDA: 77246699208.07.seat04_1d05e07270e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 3BCBA1803F9A0 for ; Thu, 10 Sep 2020 09:57:24 +0000 (UTC) X-HE-Tag: seat04_1d05e07270e5 X-Filterd-Recvd-Size: 1823 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Sep 2020 09:57:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 224FCAD2F; Thu, 10 Sep 2020 09:57:38 +0000 (UTC) Date: Thu, 10 Sep 2020 11:57:17 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 3/5] mm, page_alloc(): remove setup_pageset() Message-ID: <20200910095716.GE2285@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-4-vbabka@suse.cz> <20200910092307.GD2285@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910092307.GD2285@linux> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 3BCBA1803F9A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 10, 2020 at 11:23:07AM +0200, Oscar Salvador wrote: > On Mon, Sep 07, 2020 at 06:36:26PM +0200, Vlastimil Babka wrote: > > We initialize boot-time pagesets with setup_pageset(), which sets high and > > batch values that effectively disable pcplists. > > > > We can remove this wrapper if we just set these values for all pagesets in > > pageset_init(). Non-boot pagesets then subsequently update them to specific > > values. > > > > Signed-off-by: Vlastimil Babka > > Reviewed-by: Oscar Salvador You would need to squash here the remove of setup_pageset's declaration. And then remove it from patch#4. -- Oscar Salvador SUSE L3