linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h
@ 2020-09-10 16:13 Pintu Kumar
  2020-09-10 16:15 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: Pintu Kumar @ 2020-09-10 16:13 UTC (permalink / raw)
  To: linux-kernel, linux-mm, akpm, iamjoonsoo.kim, rientjes, penberg,
	cl
  Cc: pintu.ping, Pintu Kumar

As I was browsing through this code, I found that linux/kmemleak.h
was declared twice.

When I run ./scripts/checkincludes.pl it reported the same:
mm/slab.h: linux/kmemleak.h is included more than once.

Thus removing the last included header.

Signed-off-by: Pintu Kumar <pintu@codeaurora.org>
---
 mm/slab.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/slab.h b/mm/slab.h
index 6cc323f..95e5cc1 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -46,7 +46,6 @@ struct kmem_cache {
 #include <linux/kmemleak.h>
 #include <linux/random.h>
 #include <linux/sched/mm.h>
-#include <linux/kmemleak.h>
 
 /*
  * State of the slab allocator.
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h
  2020-09-10 16:13 [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h Pintu Kumar
@ 2020-09-10 16:15 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2020-09-10 16:15 UTC (permalink / raw)
  To: Pintu Kumar
  Cc: linux-kernel, linux-mm, akpm, iamjoonsoo.kim, rientjes, penberg,
	cl, pintu.ping

On Thu, Sep 10, 2020 at 04:13:56PM +0000, Pintu Kumar wrote:
> As I was browsing through this code, I found that linux/kmemleak.h
> was declared twice.
> 
> When I run ./scripts/checkincludes.pl it reported the same:
> mm/slab.h: linux/kmemleak.h is included more than once.

Already reported yesterday and also on August 18th.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-10 16:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-10 16:13 [PATCH] mm/slab.h: Fix duplicate include file kmemleak.h Pintu Kumar
2020-09-10 16:15 ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).