From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B44FC433E2 for ; Mon, 14 Sep 2020 20:38:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0B0F20E65 for ; Mon, 14 Sep 2020 20:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UGyqbWzq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0B0F20E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E01B16B005D; Mon, 14 Sep 2020 16:38:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB3A16B0062; Mon, 14 Sep 2020 16:38:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA2CE6B0068; Mon, 14 Sep 2020 16:38:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id B120A6B005D for ; Mon, 14 Sep 2020 16:38:29 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6B6E13623 for ; Mon, 14 Sep 2020 20:38:29 +0000 (UTC) X-FDA: 77262829938.06.flock66_54102ec2710b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 2ECD11003CCE8 for ; Mon, 14 Sep 2020 20:38:29 +0000 (UTC) X-HE-Tag: flock66_54102ec2710b X-Filterd-Recvd-Size: 7113 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 20:38:28 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id v14so498678pjd.4 for ; Mon, 14 Sep 2020 13:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=buEiFiqSMKWZbMoNpmJsFjFaGJivnld+lGWUepGeL9g=; b=UGyqbWzqEO0uyKdAw8DSpSCLJxQ8TMoNTekIvldk1LP1JLlV6RkCohDqyWrk6stvDg bFM8XTta5WUrWim6jXuJ6N5+zpYauY+eRzbUL0p90bSdzWMWFftowwsFjO2GM93q5Rkr 8eQVJoMJZbIgv8TZTmgyWrPRE2Juo95y2AXwbeRnEDMctRdsmcyniZI6xVTI6VfcILLj AtmRTMMkuISkqArmSD5jLT/Rf2Ln5Nu3OfXsdXg8cfN5OLjTUAtVYFCc1fEPQhviGorc +o0YXbbH4NdxkxLS4pD+/0TkMPUdoW+a62Ol2JUewz/3H2z/USuItXbrvgfz8fMu5z6Q CAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=buEiFiqSMKWZbMoNpmJsFjFaGJivnld+lGWUepGeL9g=; b=AEYlpOEkcexwFIgMtq6/QOshLptwKhEtH7mtCfARKwrdFqbgLq1b30DIOOm/juVHKp jl67u+vvqTywEgQUAoE3TerNqVCy9AcATHS/Pr5HSlynXpF/3/18KVLw6R86+MpjM85q wI75ijg/FX1NCYpROXukyPulCk0LyLXsUUx4Nb/nbzNHdM9Dpf5H68dAWW8kUlVlU43J CkCXbvj++Adt7+SOwKbFqRDh3zNtOocDcc6v2d5bwFZXxkqvEzrXWUoKOayHg+CShyX1 zhvC2d2QYkSYbdCvy12LLrCV8djHCmre9viS952MXGZ7PerNHzv8fIHw19GtluK/Svkn etsQ== X-Gm-Message-State: AOAM53396NV6NdNdBY16VxkCFSPh0PrmNVLfj/MH10W/sMstKlo/A4XZ R5OXQHa2eLphrlxEuS/UT4s= X-Google-Smtp-Source: ABdhPJz/S4gXFMIIlebGj6+a9mBCbtR5TNFdNCGIK6pdVitshuy3jFlp5HHM+IxT1g5DEBhfxUSWeg== X-Received: by 2002:a17:902:8491:b029:d1:9bd3:6653 with SMTP id c17-20020a1709028491b02900d19bd36653mr16315779plo.1.1600115907703; Mon, 14 Sep 2020 13:38:27 -0700 (PDT) Received: from google.com ([2620:15c:211:1:7220:84ff:fe09:5e58]) by smtp.gmail.com with ESMTPSA id i25sm9542117pgi.9.2020.09.14.13.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 13:38:26 -0700 (PDT) Date: Mon, 14 Sep 2020 13:38:24 -0700 From: Minchan Kim To: syzbot Cc: akpm@linux-foundation.org, andreyknvl@google.com, hannes@cmpxchg.org, khalid.aziz@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, rppt@linux.ibm.com, syzkaller-bugs@googlegroups.com, torvalds@linux-foundation.org Subject: Re: general protection fault in madvise_cold_or_pageout_pte_range Message-ID: <20200914203824.GA2525005@google.com> References: <00000000000002a86f05af42ab27@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00000000000002a86f05af42ab27@google.com> X-Rspamd-Queue-Id: 2ECD11003CCE8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.014352, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 14, 2020 at 02:29:15AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 729e3d09 Merge tag 'ceph-for-5.9-rc5' of git://github.com/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1482b99e900000 > kernel config: https://syzkaller.appspot.com/x/.config?x=8f5c353182ed6199 > dashboard link: https://syzkaller.appspot.com/bug?extid=ecf80462cb7d5d552bc7 > compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16e2a255900000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=164afdb3900000 > > The issue was bisected to: > > commit 1a4e58cce84ee88129d5d49c064bd2852b481357 > Author: Minchan Kim > Date: Wed Sep 25 23:49:15 2019 +0000 > > mm: introduce MADV_PAGEOUT > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=127f973e900000 > final oops: https://syzkaller.appspot.com/x/report.txt?x=117f973e900000 > console output: https://syzkaller.appspot.com/x/log.txt?x=167f973e900000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+ecf80462cb7d5d552bc7@syzkaller.appspotmail.com > Fixes: 1a4e58cce84e ("mm: introduce MADV_PAGEOUT") > > general protection fault, probably for non-canonical address 0xdffffc0000000003: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000018-0x000000000000001f] > CPU: 1 PID: 6826 Comm: syz-executor142 Not tainted 5.9.0-rc4-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:__lock_acquire+0x84/0x2ae0 kernel/locking/lockdep.c:4296 > Code: ff df 8a 04 30 84 c0 0f 85 e3 16 00 00 83 3d 56 58 35 08 00 0f 84 0e 17 00 00 83 3d 25 c7 f5 07 00 74 2c 4c 89 e8 48 c1 e8 03 <80> 3c 30 00 74 12 4c 89 ef e8 3e d1 5a 00 48 be 00 00 00 00 00 fc > RSP: 0018:ffffc90004b9f850 EFLAGS: 00010006 > RAX: 0000000000000003 RBX: 0000000000000001 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000018 > RBP: ffffc90004b9f9a8 R08: 0000000000000001 R09: 0000000000000000 > R10: fffffbfff131e2e6 R11: 0000000000000000 R12: ffff8880937161c0 > R13: 0000000000000018 R14: 0000000000000000 R15: 0000000000000000 > FS: 0000000002638880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000000002100003f CR3: 00000000a49a2000 CR4: 00000000001506e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > lock_acquire+0x140/0x6f0 kernel/locking/lockdep.c:5006 > __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] > _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 > spin_lock include/linux/spinlock.h:354 [inline] > madvise_cold_or_pageout_pte_range+0x52f/0x25c0 mm/madvise.c:389 > walk_pmd_range mm/pagewalk.c:89 [inline] > walk_pud_range mm/pagewalk.c:160 [inline] > walk_p4d_range mm/pagewalk.c:193 [inline] > walk_pgd_range mm/pagewalk.c:229 [inline] > __walk_page_range+0xe7b/0x1da0 mm/pagewalk.c:331 > walk_page_range+0x2c3/0x5c0 mm/pagewalk.c:427 > madvise_pageout_page_range mm/madvise.c:521 [inline] > madvise_pageout mm/madvise.c:557 [inline] > madvise_vma mm/madvise.c:946 [inline] > do_madvise+0x12d0/0x2090 mm/madvise.c:1145 > __do_sys_madvise mm/madvise.c:1171 [inline] > __se_sys_madvise mm/madvise.c:1169 [inline] > __x64_sys_madvise+0x76/0x80 mm/madvise.c:1169 > do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 It's the bug to access pmd again after split_huge_page of the pmd so pmd would be NULL. Let me look at it. Thanks.