From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82528C43464 for ; Fri, 18 Sep 2020 15:16:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0F4D23888 for ; Fri, 18 Sep 2020 15:16:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0F4D23888 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 38DB06B0071; Fri, 18 Sep 2020 11:16:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D3F900002; Fri, 18 Sep 2020 11:16:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231996B0071; Fri, 18 Sep 2020 11:16:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 011BB6B0071 for ; Fri, 18 Sep 2020 11:16:19 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B11141DF6 for ; Fri, 18 Sep 2020 15:16:19 +0000 (UTC) X-FDA: 77276533278.07.twist69_1611e7f2712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 84F4D1803F9A7; Fri, 18 Sep 2020 15:16:19 +0000 (UTC) X-HE-Tag: twist69_1611e7f2712c X-Filterd-Recvd-Size: 2079 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf31.hostedemail.com (Postfix) with ESMTP; Fri, 18 Sep 2020 15:16:18 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B635268BEB; Fri, 18 Sep 2020 17:16:15 +0200 (CEST) Date: Fri, 18 Sep 2020 17:16:15 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag Message-ID: <20200918151615.GA23432@lst.de> References: <20200918124533.3487701-1-hch@lst.de> <20200918124533.3487701-2-hch@lst.de> <20200918134012.GY3421308@ZenIV.linux.org.uk> <20200918134406.GA17064@lst.de> <20200918135822.GZ3421308@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918135822.GZ3421308@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote: > Said that, why not provide a variant that would take an explicit > "is it compat" argument and use it there? And have the normal > one pass in_compat_syscall() to that... That would help to not introduce a regression with this series yes. But it wouldn't fix existing bugs when io_uring is used to access read or write methods that use in_compat_syscall(). One example that I recently ran into is drivers/scsi/sg.c.