From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4839CC43463 for ; Sat, 19 Sep 2020 05:15:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 546AA21D43 for ; Sat, 19 Sep 2020 05:15:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 546AA21D43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 69D196B0062; Sat, 19 Sep 2020 01:15:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 624A66B0068; Sat, 19 Sep 2020 01:15:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EB996B006C; Sat, 19 Sep 2020 01:15:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 358146B0062 for ; Sat, 19 Sep 2020 01:15:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E69602496 for ; Sat, 19 Sep 2020 05:15:24 +0000 (UTC) X-FDA: 77278647768.22.year54_561569527131 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id BDCC918038E60 for ; Sat, 19 Sep 2020 05:15:24 +0000 (UTC) X-HE-Tag: year54_561569527131 X-Filterd-Recvd-Size: 1934 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 05:15:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 811BE68BEB; Sat, 19 Sep 2020 07:15:20 +0200 (CEST) Date: Sat, 19 Sep 2020 07:15:20 +0200 From: Christoph Hellwig To: Sergei Shtylyov Cc: Christoph Hellwig , Jens Axboe , Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-ide@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev Message-ID: <20200919051520.GA7070@lst.de> References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-3-hch@lst.de> <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 11:52:39AM +0300, Sergei Shtylyov wrote: > Hello! > > On 17.09.2020 19:57, Christoph Hellwig wrote: > >> Use blkdev_get_by_dev instead of open coding it using bdget_disk + >> blkdev_get. > > I don't see where you are removing bdget_disk() call (situated just before > the below code?)... Indeed. That's what you get for a messy last minute rebase.. :(