Re: [PATCH v38 16/24] x86/sgx: Add a page reclaimer

Jarkko Sakkinen
2020-09-23T15:07:43Z

On Tue, Sep 22, 2020 at 04:24:13PM +0200, Borislav Petkov wrote:
> On Tue, Sep 22, 2020 at 05:03:23PM +0300, Jarkko Sakkinen wrote:
> > On Tue, Sep 22, 2020 at 12:45:38PM +0200, Borislav Petkov wrote:
> > > > + * %SGX_ENCL_PAGE_VA_OFFSET_MASK: Holds the offset in the Version Array
> > > > + * (VA) page for a swapped page.
> > > > * %SGX_ENCL_PAGE_ADDR_MASK: Holds the virtual address of the page.
> > > > *
> > > > * The page address for SECS is zero and is used by the subsystem to recognize
> > >
> > > ...
> >
> > So what's wrong over here?
>
> Nothing - that's just an ellipsis: https://en.wikipedia.org/wiki/Ellipsis
>
> I do that because otherwise you'd have to scroll through pages of quoted
> mail for no good reason and that ain't friendly at all. And I notice
> people not trimming their replies and not quoting only the text they
> reply to. They should not wonder if their emails remain unread.
>
> Thx for the rest.

OK, I'm just almost paranoic in not addressing all feedback, thanks
for the explanation :-)

Like in this version, I'll try to xref all changes so it will be at
least easier spot if something is missing.

>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko