From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D1EC4363D for ; Thu, 24 Sep 2020 10:10:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C805523977 for ; Thu, 24 Sep 2020 10:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C805523977 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EFD3D6B0098; Thu, 24 Sep 2020 06:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAE8F6B0099; Thu, 24 Sep 2020 06:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9C996B009A; Thu, 24 Sep 2020 06:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id C0ED06B0098 for ; Thu, 24 Sep 2020 06:10:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 700D31EF1 for ; Thu, 24 Sep 2020 10:10:18 +0000 (UTC) X-FDA: 77297534916.16.scarf00_200b9ba2715e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 4B2C2100E4AFB for ; Thu, 24 Sep 2020 10:10:18 +0000 (UTC) X-HE-Tag: scarf00_200b9ba2715e X-Filterd-Recvd-Size: 1427 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 10:10:17 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 047AC68AFE; Thu, 24 Sep 2020 12:10:14 +0200 (CEST) Date: Thu, 24 Sep 2020 12:10:13 +0200 From: Christoph Hellwig To: Dan Carpenter Cc: hch@lst.de, xen-devel@lists.xenproject.org, Andrew Morton , linux-mm@kvack.org Subject: Re: [bug report] x86/xen: open code alloc_vm_area in arch_gnttab_valloc Message-ID: <20200924101013.GA21907@lst.de> References: <20200924085044.GA1569000@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924085044.GA1569000@mwanda> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 24, 2020 at 11:50:44AM +0300, Dan Carpenter wrote: > Hello Christoph Hellwig, > > The patch a0e7ac6b4907: "x86/xen: open code alloc_vm_area in > arch_gnttab_valloc" from Sep 23, 2020, leads to the following static > checker warning: > > arch/x86/xen/grant-table.c:110 arch_gnttab_valloc() > warn: did you mean to pass the address of 'area->ptes' This has been fixed up an done a bit differently in the current version: http://git.infradead.org/users/hch/misc.git/commitdiff/a44f0087ead305bc91cac704b99cbf27b4cca92a