From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453A5C4727D for ; Thu, 24 Sep 2020 19:40:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB4DE2311B for ; Thu, 24 Sep 2020 19:40:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB4DE2311B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3351E6B0068; Thu, 24 Sep 2020 15:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6998E0001; Thu, 24 Sep 2020 15:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224736B006E; Thu, 24 Sep 2020 15:40:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 06EBB6B0068 for ; Thu, 24 Sep 2020 15:40:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C6E2F4DCF for ; Thu, 24 Sep 2020 19:40:14 +0000 (UTC) X-FDA: 77298971148.21.land01_1a1704027161 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 94EB2180442C3 for ; Thu, 24 Sep 2020 19:40:14 +0000 (UTC) X-HE-Tag: land01_1a1704027161 X-Filterd-Recvd-Size: 5102 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 19:40:14 +0000 (UTC) Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB3F92220D; Thu, 24 Sep 2020 19:40:11 +0000 (UTC) Date: Thu, 24 Sep 2020 15:40:09 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: linux-kernel , Yafang Shao , Axel Rasmussen , Andrew Morton , Vlastimil Babka , Michel Lespinasse , Daniel Jordan , Davidlohr Bueso , linux-mm , Ingo Molnar , Joonsoo Kim Subject: Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header Message-ID: <20200924154009.4b45d56e@oasis.local.home> In-Reply-To: <20200924153517.73f5f257@oasis.local.home> References: <20200924170928.466191266@goodmis.org> <20200924171846.993048030@goodmis.org> <2006335081.68212.1600969345189.JavaMail.zimbra@efficios.com> <20200924143025.58dc3c1f@gandalf.local.home> <166273261.68446.1600974510284.JavaMail.zimbra@efficios.com> <20200924153517.73f5f257@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 24 Sep 2020 15:35:17 -0400 Steven Rostedt wrote: > > I'm ok with tracepoint_enabled(). However, I would have placed it in > > tracepoint.h rather than tracepoint-defs.h, and we should figure out > > why people complain that tracepoint.h is including headers too > > eagerly. =20 >=20 > I could see if it would work in tracepoints.h. >=20 > It might. I was just being extra cautious. Well that blew up quick! Try using tracepoint.h in include/linux/page_ref.h and arch/x86/include/asm/msr.h and see what happens. CC arch/x86/kernel/asm-offsets.s In file included from /work/git/linux-trace.git/include/linux/srcu.h:20, from /work/git/linux-trace.git/include/linux/tracepoint.h:= 16, from /work/git/linux-trace.git/arch/x86/include/asm/msr.h:= 68, from /work/git/linux-trace.git/arch/x86/include/asm/proces= sor.h:22, from /work/git/linux-trace.git/arch/x86/include/asm/cpufea= ture.h:5, from /work/git/linux-trace.git/arch/x86/include/asm/thread= _info.h:53, from /work/git/linux-trace.git/include/linux/thread_info.h= :38, from /work/git/linux-trace.git/arch/x86/include/asm/preemp= t.h:7, from /work/git/linux-trace.git/include/linux/preempt.h:78, from /work/git/linux-trace.git/include/linux/spinlock.h:51, from /work/git/linux-trace.git/include/linux/mmzone.h:8, from /work/git/linux-trace.git/include/linux/gfp.h:6, from /work/git/linux-trace.git/include/linux/slab.h:15, from /work/git/linux-trace.git/include/linux/crypto.h:20, from /work/git/linux-trace.git/arch/x86/kernel/asm-offsets= .c:9: /work/git/linux-trace.git/include/linux/rcupdate.h: In function =E2=80=98rc= u_read_lock_sched=E2=80=99: /work/git/linux-trace.git/include/linux/rcupdate.h:740:2: error: implicit d= eclaration of function =E2=80=98preempt_disable=E2=80=99 [-Werror=3Dimplici= t-function-declaration] 740 | preempt_disable(); | ^~~~~~~~~~~~~~~ /work/git/linux-trace.git/include/linux/rcupdate.h: In function =E2=80=98rc= u_read_lock_sched_notrace=E2=80=99: /work/git/linux-trace.git/include/linux/rcupdate.h:750:2: error: implicit d= eclaration of function =E2=80=98preempt_disable_notrace=E2=80=99; did you m= ean =E2=80=98paravirt_disable_iospace=E2=80=99? [-Werror=3Dimplicit-functio= n-declaration] 750 | preempt_disable_notrace(); | ^~~~~~~~~~~~~~~~~~~~~~~ | paravirt_disable_iospace /work/git/linux-trace.git/include/linux/rcupdate.h: In function =E2=80=98rc= u_read_unlock_sched=E2=80=99: /work/git/linux-trace.git/include/linux/rcupdate.h:765:2: error: implicit d= eclaration of function =E2=80=98preempt_enable=E2=80=99 [-Werror=3Dimplicit= -function-declaration] 765 | preempt_enable(); | ^~~~~~~~~~~~~~ /work/git/linux-trace.git/include/linux/rcupdate.h: In function =E2=80=98rc= u_read_unlock_sched_notrace=E2=80=99: /work/git/linux-trace.git/include/linux/rcupdate.h:772:2: error: implicit d= eclaration of function =E2=80=98preempt_enable_notrace=E2=80=99 [-Werror=3D= implicit-function-declaration] 772 | preempt_enable_notrace(); | ^~~~~~~~~~~~~~~~~~~~~~ -- Steve