From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D949BC4363D for ; Fri, 25 Sep 2020 03:10:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A89A206C1 for ; Fri, 25 Sep 2020 03:10:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jYwOpAwV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A89A206C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 883746B005C; Thu, 24 Sep 2020 23:10:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 833968E0001; Thu, 24 Sep 2020 23:10:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74A026B0062; Thu, 24 Sep 2020 23:10:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 5F8976B005C for ; Thu, 24 Sep 2020 23:10:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 26A7B181AE865 for ; Fri, 25 Sep 2020 03:10:36 +0000 (UTC) X-FDA: 77300106072.14.twist35_04061af27164 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 057CE18229835 for ; Fri, 25 Sep 2020 03:10:35 +0000 (UTC) X-HE-Tag: twist35_04061af27164 X-Filterd-Recvd-Size: 2163 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 03:10:35 +0000 (UTC) Received: from X1 (unknown [104.245.68.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D417206C1; Fri, 25 Sep 2020 03:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601003434; bh=Ds+x7kGYL6Aj7LMGPrjmzDsE6gk5ChKlSYdVj+ut8w0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jYwOpAwVfVctDlpMmjnjRUplgtiMt4mV/5scgwfkjbJ6Bo5ZjwM6v7bL0dquOqNJl cMP1JYdzy0PkLqhIbfblhX1qQY3EeW4keEDOoQtxsxTtwT6gF6md8ZIWvyY794zHBX tDCtAsNRAAu2pViXvPTs3EYpcv9VqpkEdfxURzr4= Date: Thu, 24 Sep 2020 20:10:33 -0700 From: Andrew Morton To: "Huang\, Ying" Cc: Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: swapfile: avoid split_swap_cluster() NULL pointer dereference Message-Id: <20200924201033.64e22c2915a8f2be3aacd97f@linux-foundation.org> In-Reply-To: <87v9g2blma.fsf@yhuang-dev.intel.com> References: <20200922184838.978540-1-aquini@redhat.com> <20200922124750.67a20d9764ec098b17705407@linux-foundation.org> <20200923134251.GN795820@optiplex-lnx> <20200924195914.d240877a10e22b457bd9b45d@linux-foundation.org> <87v9g2blma.fsf@yhuang-dev.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 25 Sep 2020 11:06:53 +0800 "Huang\, Ying" wrote: > >> UGH! I missed adding it to my cc list. Shall I just forward it, now, or > >> do you prefer a fresh repost? > > > > I added the cc:stable to my copy. > > Please don't merge this patch. This patch doesn't fix the bug, but hide > the real bug. I will work with Rafael on root causing and fixing. Yup, I saw the discussion and have put the patch on hold pending the outcome.