From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A64C4727D for ; Fri, 25 Sep 2020 16:26:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D130B221EC for ; Fri, 25 Sep 2020 16:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D130B221EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DBA1900005; Fri, 25 Sep 2020 12:26:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 364766B0085; Fri, 25 Sep 2020 12:26:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C5C900005; Fri, 25 Sep 2020 12:26:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 0864D6B0081 for ; Fri, 25 Sep 2020 12:26:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C2810180AD802 for ; Fri, 25 Sep 2020 16:26:52 +0000 (UTC) X-FDA: 77302112664.23.basin29_6017fcb27169 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9E45837609 for ; Fri, 25 Sep 2020 16:26:52 +0000 (UTC) X-HE-Tag: basin29_6017fcb27169 X-Filterd-Recvd-Size: 2698 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 16:26:52 +0000 (UTC) Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6F50206E5; Fri, 25 Sep 2020 16:26:49 +0000 (UTC) Date: Fri, 25 Sep 2020 12:26:47 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: paulmck , Michael Jeanson , linux-kernel , Yafang Shao , Axel Rasmussen , Andrew Morton , Vlastimil Babka , Michel Lespinasse , Daniel Jordan , Davidlohr Bueso , linux-mm , Ingo Molnar , Joonsoo Kim Subject: Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header Message-ID: <20200925122647.230decde@oasis.local.home> In-Reply-To: <965650354.69699.1601047806662.JavaMail.zimbra@efficios.com> References: <20200924170928.466191266@goodmis.org> <20200924153517.73f5f257@oasis.local.home> <221547373.69067.1600977935633.JavaMail.zimbra@efficios.com> <20200924161328.760f5e79@oasis.local.home> <1430794518.69084.1600979254425.JavaMail.zimbra@efficios.com> <20200924163331.0080b943@oasis.local.home> <176393901.69671.1601044916547.JavaMail.zimbra@efficios.com> <20200925111415.60f5334c@oasis.local.home> <965650354.69699.1601047806662.JavaMail.zimbra@efficios.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000984, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 25 Sep 2020 11:30:06 -0400 (EDT) Mathieu Desnoyers wrote: > > Anyway, I don't see any issues with the current patch set as is > > (besides the documentation fix, which I already updated locally). And > > will add this to my queue for linux-next. > > The only thing I would change in the documentation is to word this as > "here is a trampoline trick which can be used to work-around rare cases > of tracepoint header circular dependency issues" rather than "always use > this when instrumenting a header". > I rather not have tracepoints in headers. Period! It's not just about circular dependencies, it also bloats the code. -- Steve