From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0781C2D0A8 for ; Mon, 28 Sep 2020 12:57:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3ADBD2068E for ; Mon, 28 Sep 2020 12:57:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fh+YvJ9B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ADBD2068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C82346B006E; Mon, 28 Sep 2020 08:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C33176B0072; Mon, 28 Sep 2020 08:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB406B0073; Mon, 28 Sep 2020 08:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 9B59C6B006E for ; Mon, 28 Sep 2020 08:57:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5DD68180AD801 for ; Mon, 28 Sep 2020 12:57:45 +0000 (UTC) X-FDA: 77312472090.10.taste41_361119727181 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 47C4816A4A4 for ; Mon, 28 Sep 2020 12:57:41 +0000 (UTC) X-HE-Tag: taste41_361119727181 X-Filterd-Recvd-Size: 3924 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Sep 2020 12:57:40 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id z2so586141qtv.12 for ; Mon, 28 Sep 2020 05:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wDoFUE99bIcRGspOXbo3zjmN4PbXIvPVJjhLWXzP2ws=; b=fh+YvJ9Brb4kYYngrH/s/qYqgriElu1sQclUqqsUqnI6iNy73Lw71pmIIPHLpV9j4W 59/nCSWYfA/9pGsQa331v3pqyC5dMWH3s2EMmVDI+3A4EQ+MyDFAIwCT5zkaVKiutdiD WSUcE1foff3Wj638oHgA24KPnv6GD0y1GudgeynBKA6Nu51WFE993W/MIKFGyZ3ush6d ABAxCR8X8x/SGd7waBLsiY7M4rWb0PJpGnacZAdQ3fZPhRYbBVf3YEiCJS3URIz0mZTj AHIvDqoKW/ZwBWN2LF3qlDVUxFT7tspnHuVo9Kgx5rmhoUybDzdx4349SK5guLHxC5T+ 0b0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wDoFUE99bIcRGspOXbo3zjmN4PbXIvPVJjhLWXzP2ws=; b=eGI1xBQesFPyw1Tv8kZxQVIaTLmVZuISMFo87mwBFdknr+sNMtSpSUDm5DY/+1esKn dvoom3+D0sEHtHZ1hcSF6sIAvjoyjhbq8L9QAMyryQYThQ5qp3aRwdUT0fxXzzKXDNGQ POuSWCefQ08R3Mubr+nmgGd1zbiWqPsrIkJaU+Bzfq2LH91CpCnhbFYWApnNzOPnW+Vr vo3ScDqlldVs3TmUzP8A4X89uzchICVMRDLiZqpw/3TELnsCmIyps0RIDE7WL/sLyalW jTnHg2FEnpPxikV1ykLieYTgzpmwZUwiAzfNs5K7tNjMIYipA17lHhNfu8GpMHM7ugoA FsOw== X-Gm-Message-State: AOAM533pORmVTnNXkaGhaDp5qEFjOgE0hJNK7mRQJuqV4DNYn5kdEUGO B7+Iy81Au8udBGSsKfiNt9n13g== X-Google-Smtp-Source: ABdhPJxCKooSFDLWgOXoraPDbg4q0zhejQPruckFKr8pWCDzdZCLrg6aCuKusJtuOinatJbK6F9iAw== X-Received: by 2002:ac8:4a93:: with SMTP id l19mr1379042qtq.163.1601297860267; Mon, 28 Sep 2020 05:57:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id d22sm857359qkj.93.2020.09.28.05.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 05:57:39 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kMsip-001uld-4v; Mon, 28 Sep 2020 09:57:39 -0300 Date: Mon, 28 Sep 2020 09:57:39 -0300 From: Jason Gunthorpe To: John Hubbard Cc: Andrew Morton , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ralph Campbell , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h Message-ID: <20200928125739.GP9916@ziepe.ca> References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928062159.923212-3-jhubbard@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile > index d1ae706d9927..9cc6bc087461 100644 > +++ b/tools/testing/selftests/vm/Makefile > @@ -130,3 +130,5 @@ endif > $(OUTPUT)/userfaultfd: LDLIBS += -lpthread > > $(OUTPUT)/mlock-random-test: LDLIBS += -lcap > + > +$(OUTPUT)/gup_test: ../../../../mm/gup_test.h There is no reason to do this, the auto depends will pick up header files, and gup_test.h isn't a generated file Jason