From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D4AC4727E for ; Wed, 30 Sep 2020 12:36:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB5562076E for ; Wed, 30 Sep 2020 12:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uAafF/ov" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB5562076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BE11900002; Wed, 30 Sep 2020 08:36:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06DAC6B0070; Wed, 30 Sep 2020 08:36:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC60C900002; Wed, 30 Sep 2020 08:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id D67EC6B006E for ; Wed, 30 Sep 2020 08:36:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 850D0181079BB for ; Wed, 30 Sep 2020 12:36:42 +0000 (UTC) X-FDA: 77319676644.27.lunch74_2f0f4ba27192 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 5E0163D663 for ; Wed, 30 Sep 2020 12:36:42 +0000 (UTC) X-HE-Tag: lunch74_2f0f4ba27192 X-Filterd-Recvd-Size: 2831 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 12:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6tFTYb3Wzz6b6nVEOaTY19MAg+Ujicir9pWVpfj4BXw=; b=uAafF/ovoRVJBuCHGMjnocW1uJ o9ScRK+acOA2IP5Ei8tkYbSZhzXEatgM6hiwLSRffLgVhrpklA51kFiaLT1Str5aocPUOOe74mSUt aSW+79AUAFsfbkzUj7WNyhOtB0CMNXFEF1HDgf3/x5mSN1Yibb1Sj6KIVceCqC4Y4ZmjrX7aAqq9u 8sEqCJOvS8nLL34fF6FOcJvatgoF2FKOAnSxok/rCXpbAbWHlagIquRxiyBVZie3aulQnB6V3cvFm Wiw6Xtw0yyqfBtWKgjNwB6wmFADTJ8/SEXrG13LfTcCby0UCAUOft//ENpTiqepH1D1jMztURvIMX 0tZ5NY6A==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbLZ-0002y9-3K; Wed, 30 Sep 2020 12:36:37 +0000 Date: Wed, 30 Sep 2020 13:36:37 +0100 From: Matthew Wilcox To: Jan Kara Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , William Kucharski , Johannes Weiner , Yang Shi , Dave Chinner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/12] mm/filemap: Return only head pages from find_get_entries Message-ID: <20200930123637.GP20115@casper.infradead.org> References: <20200914130042.11442-1-willy@infradead.org> <20200914130042.11442-13-willy@infradead.org> <20200930121512.GT10896@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930121512.GT10896@quack2.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 02:15:12PM +0200, Jan Kara wrote: > On Mon 14-09-20 14:00:42, Matthew Wilcox (Oracle) wrote: > > All callers now expect head (and base) pages, and can handle multiple > > head pages in a single batch, so make find_get_entries() behave that way. > > Also take the opportunity to make it use the pagevec infrastructure > > instead of open-coding how pvecs behave. This has the side-effect of > > being able to append to a pagevec with existing contents, although we > > don't make use of that functionality anywhere yet. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Looks good to me. You can add: > > Reviewed-by: Jan Kara > > I'm just curious: What has happened to pagevec_lookup_entries() call in > invalidate_inode_pages2_range()? Your series appears to be based on a tree > where the call already does not exist... That went away in patch 10 of this series.