From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4641EC4727C for ; Wed, 30 Sep 2020 17:05:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C31520754 for ; Wed, 30 Sep 2020 17:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GiB1YBIn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C31520754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 241946B0071; Wed, 30 Sep 2020 13:05:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F13B6B0072; Wed, 30 Sep 2020 13:05:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DF796B0073; Wed, 30 Sep 2020 13:05:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id E97E06B0071 for ; Wed, 30 Sep 2020 13:05:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AB2B22492 for ; Wed, 30 Sep 2020 17:05:18 +0000 (UTC) X-FDA: 77320353516.09.spy15_190b1cb27194 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 8121C180B1458 for ; Wed, 30 Sep 2020 17:05:18 +0000 (UTC) X-HE-Tag: spy15_190b1cb27194 X-Filterd-Recvd-Size: 4365 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 17:05:18 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601485517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CZKcauAc0nfeHpM0es/OPCwFvNQgO5rpGzRp/Vk1ptw=; b=GiB1YBInmhXRYMJktA4guAS2BoxIgmBvttQzy/kQ9+G7MKCD96XrMpzJIBVMSfTr2Kco32 zS5fuEKTQSr8fgLEDttPOvO/Nl6FrlYRMFEQsibq7eMoR0EjgaxNhO3y58yLkGxmERWqSm yWdoKIm4ZGtM6WzaDPpFIJnmhIXoNVk= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-23uG3EeiNlSaYjqjq1ELcg-1; Wed, 30 Sep 2020 13:05:15 -0400 X-MC-Unique: 23uG3EeiNlSaYjqjq1ELcg-1 Received: by mail-qt1-f199.google.com with SMTP id f5so1661196qtk.11 for ; Wed, 30 Sep 2020 10:05:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CZKcauAc0nfeHpM0es/OPCwFvNQgO5rpGzRp/Vk1ptw=; b=Pl8eJmZJOXfUjrNOMDLcvYjxzT+DBnYdr1jsL3vehp1tJ8HgZssjLc7lMd9X0KytnH utPlcx9i3LDgGzXUJIK7+AJaeMKhNmF8fnDXwGTRmXKx7Yh/u3gzAxmhxfjM4RWwJbqM be+SYgZAmvxrgPUiMi91/LeqxGNqm4dOj7/RzeZx4fACz5w7Zo4Pu7QRh5gcNJffkS3u gw0jjt6mdwV0fxhrF5zeyeU/QDNvqFeng/xKzm1TUcvHXSCqNmpOMJ/bPVMiin+T0lJ/ hqZKGAGrG6QZad35iVSgPR1mf74V0Eim0WGwEl753ogKRczw/kzUTukUfYOlFvhBmI5M YR4A== X-Gm-Message-State: AOAM530F9qzdM6rCJZoZZ35Fb2BN/3PJtyc3qOsmg49Mf7iW0JfUIvKk vML5UMRkmcI8RZFEeuKF8FdOJTXDDAORqbfbVQTtbe0KvT0pCpd9Ctab8Bx9xIY1L6INVtkIYPX pe90eHc80A1Y= X-Received: by 2002:a05:620a:90c:: with SMTP id v12mr3462554qkv.16.1601485514558; Wed, 30 Sep 2020 10:05:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzfYHBUf5QfbzgCwdhaQpjv71pvcL4htrtAB8ovhm90oVovrzU1gnTHYUfvlNK2itvbmRDDA== X-Received: by 2002:a05:620a:90c:: with SMTP id v12mr3462492qkv.16.1601485513923; Wed, 30 Sep 2020 10:05:13 -0700 (PDT) Received: from xz-x1 (toroon474qw-lp130-09-184-147-14-204.dsl.bell.ca. [184.147.14.204]) by smtp.gmail.com with ESMTPSA id l8sm3023315qtk.77.2020.09.30.10.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 10:05:13 -0700 (PDT) Date: Wed, 30 Sep 2020 13:05:11 -0400 From: Peter Xu To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , John Hubbard , Andrew Morton , Christoph Hellwig , Yang Shi , Oleg Nesterov , Kirill Tkhai , Hugh Dickins , Jann Horn , Linus Torvalds , Michal Hocko , Jan Kara , Andrea Arcangeli , Leon Romanovsky Subject: Re: [PATCH v2 2/4] mm/fork: Pass new vma pointer into copy_page_range() Message-ID: <20200930170511.GA130406@xz-x1> References: <20200925222600.6832-1-peterx@redhat.com> <20200925222600.6832-3-peterx@redhat.com> <20200930133055.sdejarcv7nyhc2yc@box> MIME-Version: 1.0 In-Reply-To: <20200930133055.sdejarcv7nyhc2yc@box> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 04:30:55PM +0300, Kirill A. Shutemov wrote: > > int copy_page_range(struct mm_struct *dst, struct mm_struct *src, > > - struct vm_area_struct *vma); > > + struct vm_area_struct *vma, struct vm_area_struct *new); > > It makes dst/src mm_struct arguments redundant. There's always vma->vm_mm. Indeed. I'll post a patch later for it. Thanks. -- Peter Xu