From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A00EC4363D for ; Fri, 2 Oct 2020 05:56:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E513F20639 for ; Fri, 2 Oct 2020 05:56:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E513F20639 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 49EBB6B005D; Fri, 2 Oct 2020 01:56:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DA16B0062; Fri, 2 Oct 2020 01:56:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33DA96B0068; Fri, 2 Oct 2020 01:56:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 06CCC6B005D for ; Fri, 2 Oct 2020 01:56:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 985C2180AD801 for ; Fri, 2 Oct 2020 05:56:31 +0000 (UTC) X-FDA: 77325925782.03.slave76_0b03b8b271a1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 72C7628A4E8 for ; Fri, 2 Oct 2020 05:56:31 +0000 (UTC) X-Spam-Summary: 1,0,0,7efd83d39e6a9bcd,d41d8cd98f00b204,hch@lst.de,,RULES_HIT:41:355:379:599:800:960:966:973:988:989:1260:1277:1312:1313:1314:1345:1359:1437:1516:1518:1519:1534:1537:1566:1593:1594:1595:1596:1711:1714:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3871:4385:5007:6120:6261:6742:10004:10400:11232:11658:11914:12160:12296:12297:12679:12740:12895:13069:13311:13357:13439:13895:14181:14721:21080:21451:21627:30054:30064:30090:30091,0,RBL:213.95.11.211:@lst.de:.lbl8.mailshell.net-64.201.201.201 62.14.6.100;04yfeb1t9uhhek8t4dt1s7qdhpqd7ycpw785tct7ms74fu98c6c8d14uu3hcied.wsqhe6tgqummty8hcgm9f3jk5pw9wbu8qur31j3mjrf1njgaatzd7w64zdrk6ht.y-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:19,LUA_SUMMARY:none X-HE-Tag: slave76_0b03b8b271a1 X-Filterd-Recvd-Size: 1899 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 05:56:30 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8411068B02; Fri, 2 Oct 2020 07:56:27 +0200 (CEST) Date: Fri, 2 Oct 2020 07:56:27 +0200 From: Christoph Hellwig To: Ralph Campbell Cc: linux-mm@kvack.org, kvm-ppc@vger.kernel.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dan Williams , Ira Weiny , Matthew Wilcox , Jerome Glisse , John Hubbard , Alistair Popple , Christoph Hellwig , Jason Gunthorpe , Bharata B Rao , Zi Yan , "Kirill A . Shutemov" , Yang Shi , Paul Mackerras , Ben Skeggs , Andrew Morton Subject: Re: [RFC PATCH v3 1/2] ext4/xfs: add page refcount helper Message-ID: <20201002055627.GA8891@lst.de> References: <20201001181715.17416-1-rcampbell@nvidia.com> <20201001181715.17416-2-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001181715.17416-2-rcampbell@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 01, 2020 at 11:17:14AM -0700, Ralph Campbell wrote: > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell Looks good: Reviewed-by: Christoph Hellwig