From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B4BC46466 for ; Fri, 2 Oct 2020 23:33:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 950E9207EA for ; Fri, 2 Oct 2020 23:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="osG89oxu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 950E9207EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B30326B0093; Fri, 2 Oct 2020 19:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6F86B0096; Fri, 2 Oct 2020 19:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 989546B0093; Fri, 2 Oct 2020 19:33:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 683916B0093 for ; Fri, 2 Oct 2020 19:33:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EBE72180AD801 for ; Fri, 2 Oct 2020 23:32:59 +0000 (UTC) X-FDA: 77328588078.02.hate85_16162e5271a8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id BFE4B100E44F6 for ; Fri, 2 Oct 2020 23:32:59 +0000 (UTC) X-HE-Tag: hate85_16162e5271a8 X-Filterd-Recvd-Size: 4132 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 23:32:59 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id q5so4633951qkc.2 for ; Fri, 02 Oct 2020 16:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GMZiH7LK0JBwXG4v1UP0rl5OpalOGQnJVjqVY5DNpuE=; b=osG89oxuUd0YEi/7lgR001W6pRaFetREjtQvKsBf/G2TO0d3iiDAi3GxfkxQMcWS0j CmEqnKr3FhH90etHJ3wtIUkqfpgA/xNZVkpapgJsAMZgunACHcFylO1+9h/UJCKOGdLp 8iGTzCKhDGwVXhFyc67PzvKlxwqHDxIVvhrPbe+KLul28oRl7CzqzR0lFLTJiUkEmVaz wBvAD3P0Hsgw7I4yG+bPZPftF9vu9uW66bkeRZmkKkwD6cshtmNB+HolXzttsR+MpN90 RDhuL9K4K1Hlx7lvpQCUodf7ZXpf5xjhIphbDP7YThuTUMdfc3pF2fNS1phFtFq5pYhC Yleg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GMZiH7LK0JBwXG4v1UP0rl5OpalOGQnJVjqVY5DNpuE=; b=Ym2X6V4MVGttuNF4uD1TqZF8ThAv4ybyxwh4Vxc5uNbzHW65/fKg7xXs7Zcm7LH25V YP720uqDecxseguDiHx5w3Z69fJZptap0gPgkJyyqbamqQh76oZwfehJ5AwPetUTpohS YbcjnJcxBHmb58YOR5xLEI3YBSO8wBoNdnywimq8C7Li3/P7IpP3i+ag9clZYtD9emt1 ZeraoY4uUjt6cSNkxQtzhnJsMj77m+6Hhw5wpMcg3Kg73OlR2xRiE6CablAzd5h/mmz6 1/D8E9tn4tC7FHctlMEWPDoffPOoBm4TGr+3MIMyc0I3M0BalKFGMRSsxEPxix2f5rlr L1vw== X-Gm-Message-State: AOAM532f+2Ah0CJ7IQmiqREO19EBlejLsotvaXSEH5/bmFLMIWI3AcgG zqOj6WBeNFqZ0rLpOSRXgeB2SA== X-Google-Smtp-Source: ABdhPJxm+EClKfs6FuWkF0CALoyDH3g4It/uqnblZG9tNSeJybUBEdbQPbKi/8MXkyMeBYGQF/OS3w== X-Received: by 2002:a05:620a:1367:: with SMTP id d7mr4530227qkl.20.1601681578585; Fri, 02 Oct 2020 16:32:58 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id a66sm2079367qkc.52.2020.10.02.16.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 16:32:57 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kOUXp-006Mce-8c; Fri, 02 Oct 2020 20:32:57 -0300 Date: Fri, 2 Oct 2020 20:32:57 -0300 From: Jason Gunthorpe To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" , Andrew Morton Subject: Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range() Message-ID: <20201002233257.GN9916@ziepe.ca> References: <20201002192647.7161-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002192647.7161-1-peterx@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote: > Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork: > Pass new vma pointer into copy_page_range()"). > > Jason Gunthorpe also reported that the ordering of copy_page_range() is odd. > Since working at it, reorder the parameters to be logical, by (1) always put > the dst_* fields to be before src_* fields, and (2) keep the same type of > parameters together. > > CC: Jason Gunthorpe > CC: Andrew Morton > Reported-by: Kirill A. Shutemov > Signed-off-by: Peter Xu > --- > v2: > - further reorder some parameters and line format [Jason] > --- > include/linux/mm.h | 4 +- > kernel/fork.c | 2 +- > mm/memory.c | 139 ++++++++++++++++++++++++--------------------- > 3 files changed, 76 insertions(+), 69 deletions(-) Thanks, looks more readable to me Reviewed-by: Jason Gunthorpe Jason