Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4300 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-randconfig-a004-20201003 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
        git checkout 3e4248734433fea1624e4971258042af2f231e02
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:20:
   include/linux/mm.h:162:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case 72:
           ^
   include/linux/mm.h:162:2: note: insert '__attribute__((fallthrough));' to silence this warning
           case 72:
           ^
           __attribute__((fallthrough)); 
   include/linux/mm.h:162:2: note: insert 'break;' to avoid fall-through
           case 72:
           ^
           break; 
   include/linux/mm.h:164:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case 64:
           ^
   include/linux/mm.h:164:2: note: insert '__attribute__((fallthrough));' to silence this warning
           case 64:
           ^
           __attribute__((fallthrough)); 
   include/linux/mm.h:164:2: note: insert 'break;' to avoid fall-through
           case 64:
           ^
           break; 
   include/linux/mm.h:166:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case 56:
           ^
   include/linux/mm.h:166:2: note: insert '__attribute__((fallthrough));' to silence this warning
           case 56:
           ^
           __attribute__((fallthrough)); 
   include/linux/mm.h:166:2: note: insert 'break;' to avoid fall-through
           case 56:
           ^
           break; 
   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:20:
   In file included from include/linux/mm.h:1317:
>> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror,-Wimplicit-function-declaration]
           if (vmstat_item_in_bytes(item)) {
               ^
   3 warnings and 1 error generated.
   make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1139: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:179: sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h

   291	
   292	static inline void __mod_node_page_state(struct pglist_data *pgdat,
   293				enum node_stat_item item, int delta)
   294	{
 > 295		if (vmstat_item_in_bytes(item)) {
   296			VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1));
   297			delta >>= PAGE_SHIFT;
   298		}
   299	
   300		node_page_state_add(delta, pgdat, item);
   301	}
   302	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29024 bytes --]