* Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration [not found] <20201001203931.GD2706729@carbon.DHCP.thefacebook.com> @ 2020-10-02 0:08 ` kernel test robot 2020-10-02 0:55 ` Roman Gushchin 2020-10-02 21:43 ` kernel test robot 1 sibling, 1 reply; 7+ messages in thread From: kernel test robot @ 2020-10-02 0:08 UTC (permalink / raw) To: Roman Gushchin, Linus Torvalds Cc: kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt [-- Attachment #1: Type: text/plain, Size: 2586 bytes --] Hi Roman, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 base: git://git.cmpxchg.org/linux-mmotm.git master config: i386-randconfig-s002-20200930 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-201-g24bdaac6-dirty # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 git checkout 3e4248734433fea1624e4971258042af2f231e02 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/mm.h:1317, from include/linux/memcontrol.h:20, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/vmstat.h: In function '__mod_node_page_state': >> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration] 295 | if (vmstat_item_in_bytes(item)) { | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1139: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:179: sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h 291 292 static inline void __mod_node_page_state(struct pglist_data *pgdat, 293 enum node_stat_item item, int delta) 294 { > 295 if (vmstat_item_in_bytes(item)) { 296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1)); 297 delta >>= PAGE_SHIFT; 298 } 299 300 node_page_state_add(delta, pgdat, item); 301 } 302 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 33276 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration 2020-10-02 0:08 ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot @ 2020-10-02 0:55 ` Roman Gushchin 2020-10-02 5:34 ` [kbuild-all] " Philip Li 0 siblings, 1 reply; 7+ messages in thread From: Roman Gushchin @ 2020-10-02 0:55 UTC (permalink / raw) To: kernel test robot Cc: Linus Torvalds, kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > Hi Roman, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on mmotm/master] It's a bogus error, the patch was applied onto mmotm/master, which doesn't contain necessary slab controller patches. Thanks! > > url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 > base: git://git.cmpxchg.org/linux-mmotm.git master > config: i386-randconfig-s002-20200930 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.2-201-g24bdaac6-dirty > # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 > git checkout 3e4248734433fea1624e4971258042af2f231e02 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > In file included from include/linux/mm.h:1317, > from include/linux/memcontrol.h:20, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:13: > include/linux/vmstat.h: In function '__mod_node_page_state': > >> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration] > 295 | if (vmstat_item_in_bytes(item)) { > | ^~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1 > make[2]: Target '__build' not remade because of errors. > make[1]: *** [Makefile:1139: prepare0] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:179: sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h > > 291 > 292 static inline void __mod_node_page_state(struct pglist_data *pgdat, > 293 enum node_stat_item item, int delta) > 294 { > > 295 if (vmstat_item_in_bytes(item)) { > 296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1)); > 297 delta >>= PAGE_SHIFT; > 298 } > 299 > 300 node_page_state_add(delta, pgdat, item); > 301 } > 302 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_hyperkitty_list_kbuild-2Dall-40lists.01.org&d=DwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=a91mqnAqjcA0iLpnhkpBXCmVqE_BuOIny-YmkB8jp2U&s=4EiiISKLS8YORtIb2rqP7oxVeqhBmKzMHqJzWhDAuMw&e= ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration 2020-10-02 0:55 ` Roman Gushchin @ 2020-10-02 5:34 ` Philip Li 2020-10-02 17:55 ` Roman Gushchin 0 siblings, 1 reply; 7+ messages in thread From: Philip Li @ 2020-10-02 5:34 UTC (permalink / raw) To: Roman Gushchin Cc: kernel test robot, Linus Torvalds, kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > > Hi Roman, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on mmotm/master] > > It's a bogus error, the patch was applied onto mmotm/master, which doesn't > contain necessary slab controller patches. sorry for the wrong report, and thanks for the input, we will check this to see whether we can find an appropriate base for this case. Meanwhile, you can give a try to use --base option when git format patch, which helps us to have more clue when looking for base info. > > Thanks! > > > > > url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 > > base: git://git.cmpxchg.org/linux-mmotm.git master > > config: i386-randconfig-s002-20200930 (attached as .config) > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > reproduce: > > # apt-get install sparse > > # sparse version: v0.6.2-201-g24bdaac6-dirty > > # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02 > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 > > git checkout 3e4248734433fea1624e4971258042af2f231e02 > > # save the attached .config to linux build tree > > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@intel.com> > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/mm.h:1317, > > from include/linux/memcontrol.h:20, > > from include/linux/swap.h:9, > > from include/linux/suspend.h:5, > > from arch/x86/kernel/asm-offsets.c:13: > > include/linux/vmstat.h: In function '__mod_node_page_state': > > >> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration] > > 295 | if (vmstat_item_in_bytes(item)) { > > | ^~~~~~~~~~~~~~~~~~~~ > > cc1: some warnings being treated as errors > > make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1 > > make[2]: Target '__build' not remade because of errors. > > make[1]: *** [Makefile:1139: prepare0] Error 2 > > make[1]: Target 'prepare' not remade because of errors. > > make: *** [Makefile:179: sub-make] Error 2 > > make: Target 'prepare' not remade because of errors. > > > > vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h > > > > 291 > > 292 static inline void __mod_node_page_state(struct pglist_data *pgdat, > > 293 enum node_stat_item item, int delta) > > 294 { > > > 295 if (vmstat_item_in_bytes(item)) { > > 296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1)); > > 297 delta >>= PAGE_SHIFT; > > 298 } > > 299 > > 300 node_page_state_add(delta, pgdat, item); > > 301 } > > 302 > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_hyperkitty_list_kbuild-2Dall-40lists.01.org&d=DwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=a91mqnAqjcA0iLpnhkpBXCmVqE_BuOIny-YmkB8jp2U&s=4EiiISKLS8YORtIb2rqP7oxVeqhBmKzMHqJzWhDAuMw&e= > > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration 2020-10-02 5:34 ` [kbuild-all] " Philip Li @ 2020-10-02 17:55 ` Roman Gushchin 2020-10-12 23:05 ` Philip Li 0 siblings, 1 reply; 7+ messages in thread From: Roman Gushchin @ 2020-10-02 17:55 UTC (permalink / raw) To: Philip Li Cc: kernel test robot, Linus Torvalds, kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt On Fri, Oct 02, 2020 at 01:34:06PM +0800, Philip Li wrote: > On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > > > Hi Roman, > > > > > > Thank you for the patch! Yet something to improve: > > > > > > [auto build test ERROR on mmotm/master] > > > > It's a bogus error, the patch was applied onto mmotm/master, which doesn't > > contain necessary slab controller patches. > sorry for the wrong report, and thanks for the input, we will check > this to see whether we can find an appropriate base for this case. I wonder if you can look at the "Fixes" tag if the patch contains one? > Meanwhile, you can give a try to use --base option when git format patch, which > helps us to have more clue when looking for base info. Will do. Thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration 2020-10-02 17:55 ` Roman Gushchin @ 2020-10-12 23:05 ` Philip Li 2020-10-13 0:31 ` Roman Gushchin 0 siblings, 1 reply; 7+ messages in thread From: Philip Li @ 2020-10-12 23:05 UTC (permalink / raw) To: Roman Gushchin Cc: kernel test robot, Linus Torvalds, kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt On Fri, Oct 02, 2020 at 10:55:06AM -0700, Roman Gushchin wrote: > On Fri, Oct 02, 2020 at 01:34:06PM +0800, Philip Li wrote: > > On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > > > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > > > > Hi Roman, > > > > > > > > Thank you for the patch! Yet something to improve: > > > > > > > > [auto build test ERROR on mmotm/master] > > > > > > It's a bogus error, the patch was applied onto mmotm/master, which doesn't > > > contain necessary slab controller patches. > > sorry for the wrong report, and thanks for the input, we will check > > this to see whether we can find an appropriate base for this case. > > I wonder if you can look at the "Fixes" tag if the patch contains one? Thanks for the advice. Yes, we have Fixes tag as part of hint for us to analzye the possible base. For this case, "Fixes: ea426c2", the commit sha is a little short than we expected, thus ignored. We have updated matching rule now to handle such situation. > > > Meanwhile, you can give a try to use --base option when git format patch, which > > helps us to have more clue when looking for base info. > > Will do. > > Thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration 2020-10-12 23:05 ` Philip Li @ 2020-10-13 0:31 ` Roman Gushchin 0 siblings, 0 replies; 7+ messages in thread From: Roman Gushchin @ 2020-10-13 0:31 UTC (permalink / raw) To: Philip Li Cc: kernel test robot, Linus Torvalds, kbuild-all, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt On Tue, Oct 13, 2020 at 07:05:50AM +0800, Philip Li wrote: > On Fri, Oct 02, 2020 at 10:55:06AM -0700, Roman Gushchin wrote: > > On Fri, Oct 02, 2020 at 01:34:06PM +0800, Philip Li wrote: > > > On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > > > > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > > > > > Hi Roman, > > > > > > > > > > Thank you for the patch! Yet something to improve: > > > > > > > > > > [auto build test ERROR on mmotm/master] > > > > > > > > It's a bogus error, the patch was applied onto mmotm/master, which doesn't > > > > contain necessary slab controller patches. > > > sorry for the wrong report, and thanks for the input, we will check > > > this to see whether we can find an appropriate base for this case. > > > > I wonder if you can look at the "Fixes" tag if the patch contains one? > Thanks for the advice. Yes, we have Fixes tag as part of hint for us > to analzye the possible base. For this case, "Fixes: ea426c2", the commit sha > is a little short than we expected, thus ignored. We have updated matching > rule now to handle such situation. Hm, but the patch contains the full 12 chars long sha? Anyway, thank you for looking into it! It's really great to have the kernel test robot working. Thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration [not found] <20201001203931.GD2706729@carbon.DHCP.thefacebook.com> 2020-10-02 0:08 ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot @ 2020-10-02 21:43 ` kernel test robot 1 sibling, 0 replies; 7+ messages in thread From: kernel test robot @ 2020-10-02 21:43 UTC (permalink / raw) To: Roman Gushchin, Linus Torvalds Cc: kbuild-all, clang-built-linux, LKML, Bastian Bittorf, Vlastimil Babka, Andrew Morton, Linux Memory Management List, Shakeel Butt [-- Attachment #1: Type: text/plain, Size: 4300 bytes --] Hi Roman, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 base: git://git.cmpxchg.org/linux-mmotm.git master config: x86_64-randconfig-a004-20201003 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114 git checkout 3e4248734433fea1624e4971258042af2f231e02 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/x86/kernel/asm-offsets.c:13: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:20: include/linux/mm.h:162:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case 72: ^ include/linux/mm.h:162:2: note: insert '__attribute__((fallthrough));' to silence this warning case 72: ^ __attribute__((fallthrough)); include/linux/mm.h:162:2: note: insert 'break;' to avoid fall-through case 72: ^ break; include/linux/mm.h:164:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case 64: ^ include/linux/mm.h:164:2: note: insert '__attribute__((fallthrough));' to silence this warning case 64: ^ __attribute__((fallthrough)); include/linux/mm.h:164:2: note: insert 'break;' to avoid fall-through case 64: ^ break; include/linux/mm.h:166:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case 56: ^ include/linux/mm.h:166:2: note: insert '__attribute__((fallthrough));' to silence this warning case 56: ^ __attribute__((fallthrough)); include/linux/mm.h:166:2: note: insert 'break;' to avoid fall-through case 56: ^ break; In file included from arch/x86/kernel/asm-offsets.c:13: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:20: In file included from include/linux/mm.h:1317: >> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror,-Wimplicit-function-declaration] if (vmstat_item_in_bytes(item)) { ^ 3 warnings and 1 error generated. make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1139: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:179: sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h 291 292 static inline void __mod_node_page_state(struct pglist_data *pgdat, 293 enum node_stat_item item, int delta) 294 { > 295 if (vmstat_item_in_bytes(item)) { 296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1)); 297 delta >>= PAGE_SHIFT; 298 } 299 300 node_page_state_add(delta, pgdat, item); 301 } 302 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 29024 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-13 0:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201001203931.GD2706729@carbon.DHCP.thefacebook.com>
2020-10-02 0:08 ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot
2020-10-02 0:55 ` Roman Gushchin
2020-10-02 5:34 ` [kbuild-all] " Philip Li
2020-10-02 17:55 ` Roman Gushchin
2020-10-12 23:05 ` Philip Li
2020-10-13 0:31 ` Roman Gushchin
2020-10-02 21:43 ` kernel test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).