From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795F0C41604 for ; Tue, 6 Oct 2020 07:55:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B16D520760 for ; Tue, 6 Oct 2020 07:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B16D520760 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D9A26B005C; Tue, 6 Oct 2020 03:55:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AC56B005D; Tue, 6 Oct 2020 03:55:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078B86B0062; Tue, 6 Oct 2020 03:55:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id CDEF56B005C for ; Tue, 6 Oct 2020 03:55:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6356E181AE874 for ; Tue, 6 Oct 2020 07:55:49 +0000 (UTC) X-FDA: 77340741618.03.bath49_1e0c890271c5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 41D4D28A4E8 for ; Tue, 6 Oct 2020 07:55:49 +0000 (UTC) X-HE-Tag: bath49_1e0c890271c5 X-Filterd-Recvd-Size: 1968 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 6 Oct 2020 07:55:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8B04367373; Tue, 6 Oct 2020 09:55:41 +0200 (CEST) Date: Tue, 6 Oct 2020 09:55:41 +0200 From: Christoph Hellwig To: kernel test robot Cc: Christoph Hellwig , kbuild-all@lists.01.org, Tvrtko Ursulin , Andrew Morton , Linux Memory Management List Subject: Re: [linux-next:master 13152/13159] drivers/gpu/drm/i915/gt/shmem_utils.c:76 shmem_pin_map() warn: always true condition '(--i >= 0) => (0-u64max >= 0)' Message-ID: <20201006075541.GA10243@lst.de> References: <202010040517.GzLE38rk-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010040517.GzLE38rk-lkp@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for the report. The patch below takes care of it, and also uses the right type for a page index. Andrew, can you fold it in? diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/drivers/gpu/drm/i915/gt/shmem_utils.c index f011ea42487e11..4f043f2520f78d 100644 --- a/drivers/gpu/drm/i915/gt/shmem_utils.c +++ b/drivers/gpu/drm/i915/gt/shmem_utils.c @@ -52,7 +52,7 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj) void *shmem_pin_map(struct file *file) { struct page **pages; - size_t n_pages, i; + pgoff_t n_pages, i, j; void *vaddr; n_pages = file->f_mapping->host->i_size >> PAGE_SHIFT; @@ -73,8 +73,8 @@ void *shmem_pin_map(struct file *file) mapping_set_unevictable(file->f_mapping); return vaddr; err_page: - while (--i >= 0) - put_page(pages[i]); + for (j = 0; j < i; j++) + put_page(pages[j]); kvfree(pages); return NULL; }