From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CFAC3279D for ; Wed, 7 Oct 2020 03:20:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B30D2076C for ; Wed, 7 Oct 2020 03:20:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MFsCGRvp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B30D2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6880F6B005C; Tue, 6 Oct 2020 23:20:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 639F66B0062; Tue, 6 Oct 2020 23:20:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5015F900002; Tue, 6 Oct 2020 23:20:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 23ABB6B005C for ; Tue, 6 Oct 2020 23:20:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AA65A181AE870 for ; Wed, 7 Oct 2020 03:20:19 +0000 (UTC) X-FDA: 77343676158.19.trail64_09163ed271cc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 88DE81AD1B7 for ; Wed, 7 Oct 2020 03:20:19 +0000 (UTC) X-HE-Tag: trail64_09163ed271cc X-Filterd-Recvd-Size: 2503 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 03:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3lLD0zvE4MJ6obA1X6t1ltm+Ls0OGSfFYsuDvjn+1S8=; b=MFsCGRvpNGRCh6eLvXW6qRDO6U G6brFP4dYd07RmCnkYA3fdM35fYCPeiKMMESZIx9O57f4aY5UNVSW6K24NAR2Xn/mj0zmCP+dI286 EpCC1FbhsCFYKQI0vz1pjzwR3gv/NZS8msguVo1g9yxnYqZy89Y5JNJRScdUyUiUk0+lnvcvifs7/ rb47ggI0zem2nvCvPMnSkCz2L19v0sKDFLUSM+bCUxO+rIcb275xOYiD3yFFcYy27sAzyffQlpRgN U4dNouLq2u8MEXdEQlIbeAp+P3DeNM9KYlenMPc18NUgV6yr2EVy4NFF8GaTakhdK+mlDea/lqYPI 99wlsaqw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPzzx-0005dE-Db; Wed, 07 Oct 2020 03:20:13 +0000 Date: Wed, 7 Oct 2020 04:20:13 +0100 From: Matthew Wilcox To: jglisse@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Alexander Viro , Tejun Heo , Jan Kara , Josef Bacik Subject: Re: [PATCH 00/14] Small step toward KSM for file back page. Message-ID: <20201007032013.GS20115@casper.infradead.org> References: <20201007010603.3452458-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007010603.3452458-1-jglisse@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 06, 2020 at 09:05:49PM -0400, jglisse@redhat.com wrote: > The present patchset just add mapping argument to the various vfs call- > backs. It does not make use of that new parameter to avoid regression. > I am posting this whole things as small contain patchset as it is rather > big and i would like to make progress step by step. Well, that's the problem. This patch set is gigantic and unreviewable. And it has no benefits. The idea you present here was discussed at LSFMM in Utah and I recall absolutely nobody being in favour of it. You claim many wonderful features will be unlocked by this, but I think they can all be achieved without doing any of this very disruptive work. > 118 files changed, 722 insertions(+), 385 deletions(-) mmm.