From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F588C433E7 for ; Mon, 12 Oct 2020 12:56:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0C2F21BE5 for ; Mon, 12 Oct 2020 12:56:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iha3NUoc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0C2F21BE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B02694000A; Mon, 12 Oct 2020 08:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 568A9940007; Mon, 12 Oct 2020 08:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44E6094000A; Mon, 12 Oct 2020 08:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 0E336940007 for ; Mon, 12 Oct 2020 08:56:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 97F191EE6 for ; Mon, 12 Oct 2020 12:56:01 +0000 (UTC) X-FDA: 77363270922.11.note75_08142ea271fa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 710FD180F8B82 for ; Mon, 12 Oct 2020 12:56:01 +0000 (UTC) X-HE-Tag: note75_08142ea271fa X-Filterd-Recvd-Size: 5291 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 12 Oct 2020 12:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602507360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7P2vBNnGvTj7ryjZqgBDKBivuPaDY4fI99105fL53IE=; b=iha3NUocjIstH/s/P2w9AXO3G+rmtnxSPyZuCNro1hV4+49+Op6lUBCVYuti4OCl7cVJTK iHAJjqFUfIgUp4x7dtdhfmU7yQNJrMv9KDwvDrZ5gBtVqpaDKUj+IMRO+GEy2sB5wMpJTm IettSAzmnUJY8/+eRRqQzNmLyF8yV2s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-437-5FQdEEU9MSCnx-uOaL-vSw-1; Mon, 12 Oct 2020 08:55:58 -0400 X-MC-Unique: 5FQdEEU9MSCnx-uOaL-vSw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 692ED801FD4; Mon, 12 Oct 2020 12:55:57 +0000 (UTC) Received: from t480s.redhat.com (ovpn-113-251.ams2.redhat.com [10.36.113.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1B1460C07; Mon, 12 Oct 2020 12:55:49 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , David Hildenbrand , Jason Wang , Pankaj Gupta Subject: [PATCH v1 18/29] virtio-mem: factor out calculation of the bit number within the sb_states bitmap Date: Mon, 12 Oct 2020 14:53:12 +0200 Message-Id: <20201012125323.17509-19-david@redhat.com> In-Reply-To: <20201012125323.17509-1-david@redhat.com> References: <20201012125323.17509-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The calculation is already complicated enough, let's limit it to one location. Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Pankaj Gupta Signed-off-by: David Hildenbrand --- drivers/virtio/virtio_mem.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 2cc497ad8298..73ff6e9ba839 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -327,6 +327,16 @@ static int virtio_mem_sbm_mb_states_prepare_next_mb(= struct virtio_mem *vm) _mb_id--) \ if (virtio_mem_sbm_get_mb_state(_vm, _mb_id) =3D=3D _state) =20 +/* + * Calculate the bit number in the sb_states bitmap for the given subblo= ck + * inside the given memory block. + */ +static int virtio_mem_sbm_sb_state_bit_nr(struct virtio_mem *vm, + unsigned long mb_id, int sb_id) +{ + return (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb + sb_id; +} + /* * Mark all selected subblocks plugged. * @@ -336,7 +346,7 @@ static void virtio_mem_sbm_set_sb_plugged(struct virt= io_mem *vm, unsigned long mb_id, int sb_id, int count) { - const int bit =3D (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb + sb_id; + const int bit =3D virtio_mem_sbm_sb_state_bit_nr(vm, mb_id, sb_id); =20 __bitmap_set(vm->sbm.sb_states, bit, count); } @@ -350,7 +360,7 @@ static void virtio_mem_sbm_set_sb_unplugged(struct vi= rtio_mem *vm, unsigned long mb_id, int sb_id, int count) { - const int bit =3D (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb + sb_id; + const int bit =3D virtio_mem_sbm_sb_state_bit_nr(vm, mb_id, sb_id); =20 __bitmap_clear(vm->sbm.sb_states, bit, count); } @@ -362,7 +372,7 @@ static bool virtio_mem_sbm_test_sb_plugged(struct vir= tio_mem *vm, unsigned long mb_id, int sb_id, int count) { - const int bit =3D (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb + sb_id; + const int bit =3D virtio_mem_sbm_sb_state_bit_nr(vm, mb_id, sb_id); =20 if (count =3D=3D 1) return test_bit(bit, vm->sbm.sb_states); @@ -379,7 +389,7 @@ static bool virtio_mem_sbm_test_sb_unplugged(struct v= irtio_mem *vm, unsigned long mb_id, int sb_id, int count) { - const int bit =3D (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb + sb_id; + const int bit =3D virtio_mem_sbm_sb_state_bit_nr(vm, mb_id, sb_id); =20 /* TODO: Helper similar to bitmap_set() */ return find_next_bit(vm->sbm.sb_states, bit + count, bit) >=3D @@ -393,7 +403,7 @@ static bool virtio_mem_sbm_test_sb_unplugged(struct v= irtio_mem *vm, static int virtio_mem_sbm_first_unplugged_sb(struct virtio_mem *vm, unsigned long mb_id) { - const int bit =3D (mb_id - vm->first_mb_id) * vm->nb_sb_per_mb; + const int bit =3D virtio_mem_sbm_sb_state_bit_nr(vm, mb_id, 0); =20 return find_next_zero_bit(vm->sbm.sb_states, bit + vm->nb_sb_per_mb, bit) - bit; --=20 2.26.2