From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB23C433E7 for ; Tue, 13 Oct 2020 12:02:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFC802080A for ; Tue, 13 Oct 2020 12:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1lTKRo9F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFC802080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E34CF900003; Tue, 13 Oct 2020 08:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE523900002; Tue, 13 Oct 2020 08:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF9F0900003; Tue, 13 Oct 2020 08:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 9B7C9900002 for ; Tue, 13 Oct 2020 08:02:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 35552180AD815 for ; Tue, 13 Oct 2020 12:02:51 +0000 (UTC) X-FDA: 77366765742.15.way19_270140827203 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id C348B1814B0D2 for ; Tue, 13 Oct 2020 12:02:47 +0000 (UTC) X-HE-Tag: way19_270140827203 X-Filterd-Recvd-Size: 3340 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 12:02:47 +0000 (UTC) Received: from kernel.org (unknown [87.71.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 132CE206D9; Tue, 13 Oct 2020 12:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602590566; bh=TDZn7whmFHZ7mrQRSKL+Shf6LpSB+qKaiSmTZfuhXGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1lTKRo9Fkbx5SS+0a7Ss0Z9OpBU9P5lfkmHgFBdwWd5HZbvbbRcfTtYYqO3NT98MG kQNIss+PV0qOGJsL4V/igBwzEJNjnuDRxSEe2+rhC0Yp9kADgwU70grmtdaYaFHV1s 40BaXgmJgEF+UQyaudOBACm7e/ioGiGLeYRu6mQs= Date: Tue, 13 Oct 2020 15:02:38 +0300 From: Mike Rapoport To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 55/80] memblock: get rid of a :c:type leftover Message-ID: <20201013120238.GE4251@kernel.org> References: <4d161da11361ce386e7885873f6f4e014f0f2c99.1602589096.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d161da11361ce386e7885873f6f4e014f0f2c99.1602589096.git.mchehab+huawei@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 13, 2020 at 01:54:10PM +0200, Mauro Carvalho Chehab wrote: > chanseset b3a7bb1851c8 ("docs: get rid of :c:type explicit declarations for structs") > removed several :c:type: markups, except by one. > > Now, Sphinx 3.x complains about it: > > .../Documentation/core-api/boot-time-mm:26: ../mm/memblock.c:51: WARNING: Unparseable C cross-reference: 'struct\nmemblock_type' > Invalid C declaration: Expected identifier in nested name, got keyword: struct [error at 6] > struct > memblock_type > ------^ > > As, on Sphinx 3.x, the right markup is c:struct:`foo`. > > So, let's remove it, relying on automarkup.py to convert it. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Mike Rapoport > --- > mm/memblock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 670216826940..a06e68b1e5a0 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -50,8 +50,8 @@ > * > * Each region is represented by struct memblock_region that > * defines the region extents, its attributes and NUMA node id on NUMA > - * systems. Every memory type is described by the :c:type:`struct > - * memblock_type` which contains an array of memory regions along with > + * systems. Every memory type is described by the struct memblock_type > + * which contains an array of memory regions along with > * the allocator metadata. The "memory" and "reserved" types are nicely > * wrapped with struct memblock. This structure is statically > * initialized at build time. The region arrays are initially sized to > -- > 2.26.2 > -- Sincerely yours, Mike.