From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BEFC433DF for ; Tue, 13 Oct 2020 23:56:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 63D9E2222E for ; Tue, 13 Oct 2020 23:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PKnd4hLQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63D9E2222E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00A0A940010; Tue, 13 Oct 2020 19:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFB6D940007; Tue, 13 Oct 2020 19:56:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38F0940010; Tue, 13 Oct 2020 19:56:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id B7A9F940007 for ; Tue, 13 Oct 2020 19:56:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 55A453623 for ; Tue, 13 Oct 2020 23:56:57 +0000 (UTC) X-FDA: 77368565274.01.dog86_4e026a127207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 271C71004649E for ; Tue, 13 Oct 2020 23:56:57 +0000 (UTC) X-HE-Tag: dog86_4e026a127207 X-Filterd-Recvd-Size: 2358 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:56:56 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C01112222F; Tue, 13 Oct 2020 23:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602633416; bh=thfvBQYVqxf+ssDdjOcetoODjOIxNkdIcCqgNk9q4os=; h=Date:From:To:Subject:In-Reply-To:From; b=PKnd4hLQJ1PEAPFckAH5wKg7ph+r3+j8n6hgsh/7H7V/Aa5I7sm0kuCeZrabCgVE8 wv9hO6x8clbCVPAQ12yVoAAs0sYFTyFrq5aFA5NakE9BWJT8nm/pD/72bLQHE9jvCb KkumOmS2W70gRnIGHAyR3YJh7On6dHraUDqm8qrA= Date: Tue, 13 Oct 2020 16:56:55 -0700 From: Andrew Morton To: akpm@linux-foundation.org, chenxiang66@hisilicon.com, david@redhat.com, ddstreet@ieee.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, sjenning@redhat.com, torvalds@linux-foundation.org Subject: [patch 155/181] mm/zbud: remove redundant initialization Message-ID: <20201013235655.u5gEzxH1n%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Xiang Chen Subject: mm/zbud: remove redundant initialization zhdr is already initialized in the front of the function, so remove redundant initialization here. Link: https://lkml.kernel.org/r/1600419885-191907-1-git-send-email-chenxiang66@hisilicon.com Signed-off-by: Xiang Chen Reviewed-by: David Hildenbrand Cc: Seth Jennings Cc: Dan Streetman Signed-off-by: Andrew Morton --- mm/zbud.c | 1 - 1 file changed, 1 deletion(-) --- a/mm/zbud.c~mm-zbud-remove-redundant-initialization +++ a/mm/zbud.c @@ -367,7 +367,6 @@ int zbud_alloc(struct zbud_pool *pool, s spin_lock(&pool->lock); /* First, try to find an unbuddied zbud page. */ - zhdr = NULL; for_each_unbuddied_list(i, chunks) { if (!list_empty(&pool->unbuddied[i])) { zhdr = list_first_entry(&pool->unbuddied[i], _